powerup-android
powerup-android copied to clipboard
Able to buy from store without points reduction
Description
As a developer, I need to dismiss the dialog on "may be later" click, so that it revert back to last dress/accessory used by avatar & maintain consistency within application
Mocks
Acceptance Criteria
- [ ] Store trial item should revert back on "may be later" click.
Update [Required]
- [ ] Store activity
Definition of Done
- [ ] All of the required items are completed.
- [ ] Approval by 1 mentor.
Estimation
12 hours
Hey @geekanamika I think this is similar to #998
@Rimjhim28 It does involves points mentioned by you in #998. Going by your description , You haven't mentioned that it should revert back if "may be later" is clicked. You're mentioning the case that It should not apply directly to avatar & I'm talking about reverting back (Even if it's applied). Can you please check the gif upload by me ?
Ok let me clear it up a bit. The task from which this issue arose said that the user should be first presented with a warning dialog from which she could either buy the accessory or dismiss the dialog (The iOS version has a similar implementation )The basic error here as explained by me in #998 was that the item was set on the avatar without user confirming the purchase. So the rectification required is the item should not set on avatar until the user confirms the purchase. I have solved this on my repo. You can look at the PR I created on my repo: https://github.com/Rimjhim28/powerup-android/pull/2 "purchase" sets the item on avatar and reduces the points accordingly and "may be later" dismisses the dialog.
@m-murad Can you please review this issue ?
@geekanamika valid issue
@geekanamika The issue is approved. If you are not working on this, can I take this up?
I missed it somehow. Go ahead @Rimjhim28 :)
May I please work on this?
@geekanamika Currently what is the status of this Issue and what work is to be done on this? There are a lot of PR's on this but I can't really understand what part of it is left and what is done and what is the enhancement?