portal icon indicating copy to clipboard operation
portal copied to clipboard

docs: Updated the Docker setup for portal

Open husainattar opened this issue 4 years ago • 14 comments

Description

Updated the docker-compose.yml,settings.py, Dockerfile and Readme.md for easy project installation process through docker.

Fixes # 581

Type of Change:

Delete irrelevant options.

  • Code
  • Documentation

Code/Quality Assurance Only

  • Bugfix (non-breaking change which fixes an issue)

How Has This Been Tested?

portaldocker

Checklist:

Delete irrelevant options.

  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • [x] My changes generate no new warnings

husainattar avatar Jul 22 '20 21:07 husainattar

@husainattar There are failing tests, please push the changes to these.

sakshi1499 avatar Jul 24 '20 06:07 sakshi1499

Hi @sakshi1499 actually I have not much idea with TRAVIS-CI and I have somehow resolved the failure regarding pull request build but I don't know how to resolve the failure regarding CHECK COMMIT MESSAGES.

husainattar avatar Jul 24 '20 13:07 husainattar

@husainattar Actually you have 15 commits and one of them doesn't follow the Commit Guidelines so squash them and the new commit should follow the commit guideline.

sakshi1499 avatar Jul 24 '20 13:07 sakshi1499

@sakshi1499 ohk so I should squash all the 15 commits and create a single one commit as per guidelines?

husainattar avatar Jul 24 '20 13:07 husainattar

@husainattar There is an issue with the recent commit message checker, it does not allow capital letters in the subject

https://github.com/anitab-org/portal/pull/624 should fix this.

SanketDG avatar Jul 24 '20 21:07 SanketDG

Ohh Thank you @SanketDG

husainattar avatar Jul 24 '20 21:07 husainattar

@husainattar Feel free to squash the commits together! That should let go of the errors.

SanketDG avatar Jul 27 '20 19:07 SanketDG

Hi @SanketDG sir I actually tried everything and also squash the commit but still it provides me check-commits error. I would be grateful if anyone can provide help in this.Thank you

husainattar avatar Jul 27 '20 21:07 husainattar

@husainattar Should be fixed now! I will review this PR some time later.

SanketDG avatar Jul 28 '20 16:07 SanketDG

Thank you @SanketDG sir thank you for the help.

husainattar avatar Jul 28 '20 16:07 husainattar

Btw @SanketDG I have included some important additional commands for database and common related issues in documentation. I have just not included on how we can make changes during development and get reflect in running container instantly.

husainattar avatar Aug 11 '20 18:08 husainattar

@sakshi1499 ohk so I should squash all the 15 commits and create a single one commit as per guidelines?

yes squash it and make a single commit with all changes done in description

Rajpratik71 avatar Aug 20 '20 10:08 Rajpratik71

Also , @husainattar to update your working branch with Upstream branch , you can do "git rebase" instead of merging it . This approach doesn't create a new commit in your branch.

Rajpratik71 avatar Aug 20 '20 11:08 Rajpratik71

@husainattar Are you working on this?

sakshi1499 avatar Sep 23 '20 13:09 sakshi1499