portal
portal copied to clipboard
Added start time and an end time in Meetup.
Description
As the description of the issue, it requires that the meetup has a start time and end time. In this issue, I have made changes to support both start time and end time of the respective meetup. I found 1 error while working on this issue that while logging out, it gives an error. I make changes to this to resolve the logout error. I have modified and add the test cases to support my modified for start time and end time.
Fixes #432 #526
Type of Change:
- Code
- Quality Assurance
- User Interface
Code/Quality Assurance Only
- New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?
I have tested it locally and modify test cases to support my changes.
Before changes, Meetup view looks like this.
After changes, Meetup view looks like this.
Before changes, Editing Meetup looks like this.
After changes, Editing Meetup looks like this.
Before changes, Adding Meetup looks like this.
After changes, Adding Meetup looks like this.
Before changes adding meetup via admin panel looks like this.
After changes adding meetup via admin panel looks like this.
Upcoming Meetup

I have also modified code for the logout button which faces some issue while logout. Before while logging out gives an error.
After changes not giving such error.
Checklist:
- [ ] My PR follows the style guidelines of this project
- [ ] I have performed a self-review of my own code or materials
Code/Quality Assurance Only
- [ ] I have modified some tests that prove my fix is effective or that my feature works
- [ ] Modified and existing unit tests pass locally with my changes
@satya7289 Why did you change the logout URL name? Also, if you have the start_time and end_time fields, what is the time field for?
@satya7289 Why did you change the logout URL name? Also, if you have the start_time and end_time fields, what is the time field for?
-
The logout URL name is changed because while logging it gives the error which I attached above. Also while running test cases, it gives error here. Also, we are using Django-allauth so logout URL should be according to Django-allauth(account_logout).
-
I don't add time field. But I guess it is for the duration of the event. I only add start_time, end_time, and time field is already there. @sammy1997
@satya7289 I don't recommend changing the URL name in this PR. If the problem persists, we can open another issue on that. I also second @sammy1997 on the other point. Having a time field is redundant.
Please let me know if this PR still needed. @sakshi1499 @sammy1997 @SanketDG
@satya7289 This PR is definitely relevant and We are making changes on this page through one of the other Prs.