portal icon indicating copy to clipboard operation
portal copied to clipboard

Add jobs of pylint, docs, formatting in .travis.yml

Open bismitaguha opened this issue 4 years ago • 6 comments

Description

As a contributor, I need to make respective tests for each contribution, so that I can ensure proper code-checks

Mocks

N/A

Acceptance Criteria

Update [Required]

  • [x] .travis.yml

Enhancement to Update [Optional]

  • [x] Travis CI tests

Definition of Done

  • [x] All of the required items are completed.
  • [x] Approval by 1 mentor.

Estimation

1.5 hours

bismitaguha avatar Mar 16 '20 17:03 bismitaguha

@sammy1997 @isabelcosta I would like to work on this issue. Please add the respective labels and assign it to me.

bismitaguha avatar Mar 16 '20 17:03 bismitaguha

Can you explain a bit about the changes you want to make?

sammy1997 avatar Mar 16 '20 18:03 sammy1997

@sammy1997 I wish to add jobs for python testing. No jobs are currently added in the .travis.yml. Adding jobs of pylint, docs and formatting will check all the formatting and pylint errors in the code before the build. This will maintain the code quality and check linting of every PR.

bismitaguha avatar Mar 16 '20 18:03 bismitaguha

Ok. Seems valid. Approving this

sammy1997 avatar Mar 17 '20 05:03 sammy1997

Adding a Pylint might cause the build to fail though. Don't send a PR yet. We need to discuss whether we want that in travis or do we want to add codacy for separate linting checks like VMS. We already have a flake test

sammy1997 avatar Mar 17 '20 05:03 sammy1997

Codacy is a better option as its only purpose is checking code quality. Travis CI can be kept separate only for the build purpose. Flake test is a part of pytest. We can use the complete features of pytest, not staying just limited to flake test. @sammy1997 What are your suggestions on this?

bismitaguha avatar Mar 17 '20 09:03 bismitaguha