mentorship-flutter
mentorship-flutter copied to clipboard
anitab-org
feat: add Task Comments
Description
Add comments to tasks :) Haven't added names yet because it becomes too complicated to pass the data around. Zulip thread here
Fixes #111
Flutter Channel:
- [x] I have used the Flutter Beta channel on my local machine
Type of Change:
Delete irrelevant options.
- Code
Code/Quality Assurance Only
- New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?
Physical device
Checklist:
Delete irrelevant options.
- [x] My PR follows the style guidelines of this project
- [x] I have performed a self-review of my own code or materials
- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] Any dependent changes have been merged
@Techno-Disaster can you fix merge conflicts and we can move the ball forward :)
@isabelcosta any updates? @anitab-org/coding-team could anyone give this a quick review?
i didn't look at this app in quite a long time and it's looking more and more amazing:) good job, approving it
@anitab-org/qa-team can anyone test this PR please? this feature it's quite interesting :) @Techno-Disaster, can you let us know where to find the APK?
@anitab-org/qa-team can anyone test this PR please? this feature it's quite interesting :) @Techno-Disaster, can you let us know where to find the APK?
Head on over to the checks tab . You will see a artifacts dropdown on that page. You can download a zip which contains a apk from that dropdown
@isabelcosta @anitab-org/coding-team this seems like a backend issue? could you check the logs.
@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?
@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?
on android studio
@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?
on android studio
ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account?
username : ursula pwd: 12345678
@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?
on android studio
ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account?
username : ursula pwd: 12345678
hmm.. using this account , but its this using the same server/backend ? also, the PR should be generic and not specific i mean if it works for this account then it should also work using any ?
@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?
on android studio
ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account? username : ursula pwd: 12345678
hmm.. using this account , but its this using the same server/backend ? also, the PR should be generic and not specific i mean if it works for this account then it should also work using any ?
yes, it uses the same backend but even @yugantarjain faced this issue in which some accounts were able to make comments while others were getting internal server error. @isabelcosta can confirm this, we had a discussion on this in one of the sessions. So it shouldn't be blocking this PR
@yugantarjain what accounts did you use for the comments feature? Almost all mine work if i setup the backend locallly, but were you able to get any account working on the one hosted on heroku?
@anitab-org/mentorship-flutter-maintainers can you review this again? Also @robotjellyzone were you able to test comments? if you want a workaround for the backend error, you can check the completed comments on the ursula account. Comments work there
@Techno-Disaster make sure to also ping on Zulip, even invite newcomers to review the PR and test it :) This is advocate work, and can help onboard new people to the project.