mentorship-flutter icon indicating copy to clipboard operation
mentorship-flutter copied to clipboard

feat: Removed tabs when user does not has any relation. Fix for issue #122

Open justdvnsh opened this issue 4 years ago • 9 comments

Description

Removed the App bar when the user has no relation.

Fixes #122

Flutter Channel:

  • [ ] I have used the Flutter Beta channel on my local machine

Type of Change:

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • New feature (Tab bar hides when user has no relation)

How Has This Been Tested?

https://drive.google.com/file/d/1AOvgBenhTe5d_GP-OcdszVjYKaufK1Jc/view?usp=sharing

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials

justdvnsh avatar Aug 03 '20 11:08 justdvnsh

Screenshots

https://drive.google.com/file/d/1AHhAUJlfUkC1knQfMimfudXNhafD0Kig/view?usp=sharing

justdvnsh avatar Aug 03 '20 11:08 justdvnsh

@justdvnsh can you add a gif showing this? also can you check if pull down to refresh works in that gif? Thank you for your contribution.

techno-disaster avatar Aug 03 '20 11:08 techno-disaster

Description

Removed the App bar when the user has no relation.

Fixes #122

Flutter Channel:

* [ ]  I have used the Flutter Beta channel on my local machine

Type of Change:

* Code

* Quality Assurance

* User Interface

Code/Quality Assurance Only

* New feature (Tab bar hides when user has no relation)

How Has This Been Tested?

https://drive.google.com/file/d/1AOvgBenhTe5d_GP-OcdszVjYKaufK1Jc/view?usp=sharing

Checklist:

* [*] My PR follows the style guidelines of this project

* [*] I have performed a self-review of my own code or materials

FYI its - [ x ] to check the box in markdown

techno-disaster avatar Aug 03 '20 11:08 techno-disaster

@Techno-Disaster Yeah. sure. I will add the GIF and thanks for the checkmark information.

justdvnsh avatar Aug 03 '20 11:08 justdvnsh

@Techno-Disaster Hi. Here is the GIF. https://drive.google.com/file/d/1AmVMmgejjUruhOwkitXTigLP5uXcecBM/view?usp=sharing Also, how can i remove .idea files from the commit. I tried git rm --cached -r .idea but no luck !!

justdvnsh avatar Aug 04 '20 11:08 justdvnsh

@justdvnsh Could you add the gif in the PR body itself? way more convenient for the other maintainers and myself to review. Also I'll manually test the PR later today and update. Thanks for your contribution

techno-disaster avatar Aug 04 '20 13:08 techno-disaster

@Techno-Disaster The Gif is uploaded to google drive. I tried putting it in this PR body, but it is not happening. Only the link is being shared.

justdvnsh avatar Aug 06 '20 08:08 justdvnsh

@Techno-Disaster The Gif is uploaded to google drive. I tried putting it in this PR body, but it is not happening. Only the link is being shared.

You should try adding the gif directly to the markdown not google drive, check this out

techno-disaster avatar Aug 06 '20 10:08 techno-disaster

Hi. @Techno-Disaster. I have changed the files according to the requested changes. Can you please review it now ?

justdvnsh avatar Aug 31 '20 19:08 justdvnsh