mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Make mentioned changes in resources files to follow the same convention

Open PrashanthPuneriya opened this issue 5 years ago • 5 comments

Description

As a contributor, I need consistent style followed in resources file, so that I don't get confused that whether some part of the code is missing or not.

Mocks

https://github.com/anitab-org/mentorship-backend/blob/6fe6929fed2007ed43242f36c44f9bcca1d79979/app/api/resources/user.py#L171-L182 Here the route is below the responses which breaks the convention. https://github.com/anitab-org/mentorship-backend/blob/6fe6929fed2007ed43242f36c44f9bcca1d79979/app/api/resources/user.py#L247-L268 Here the responses aren't attached with the route function but with the put().

Acceptance Criteria

Update [Required]

  • [ ] Make the above mentioned changes in the code to follow the same convention throughout the file.
  • [ ] Check the same with other resources files and fix them if such convetion is broken.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

4 hours

PrashanthPuneriya avatar Sep 26 '20 13:09 PrashanthPuneriya

Can I take up this issue?

gitpurva avatar Sep 26 '20 16:09 gitpurva

Sure @gitpurva

PrashanthPuneriya avatar Sep 26 '20 16:09 PrashanthPuneriya

Any progress @gitpurva?

PrashanthPuneriya avatar Sep 28 '20 14:09 PrashanthPuneriya

I will submit the PR by tomorrow.

On Mon, Sep 28, 2020, 7:55 PM Prashanth Puneriya [email protected] wrote:

Any progress @gitpurva https://github.com/gitpurva?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/mentorship-backend/issues/898#issuecomment-700041700, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKVEGYCVQCYSBKKTGCXH2LSICMGZANCNFSM4R25DNAA .

gitpurva avatar Sep 28 '20 14:09 gitpurva

@isabelcosta putting this on hold as what needs to be done not seems to be clearly mentioned in this issue.

devkapilbansal avatar Feb 28 '21 12:02 devkapilbansal