mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Deprecate 'slack_username' field in Mentorship System API

Open paritoshsinghrahar opened this issue 4 years ago • 12 comments

Description

As a member of the app, I need be able to find members on Zulip Chat, so that I can talk to the member.

Currently, it's labelled as field slack_username. We have moved to Zulip. I want you to depreciate the field as it serves no purpose anymore across all instances of the REST API.

Mocks

image

Acceptance Criteria

Update [Required]

  • [ ] Depreciate slack_username field across all instances of the REST APIs.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

[4] hours

paritoshsinghrahar avatar Sep 16 '20 00:09 paritoshsinghrahar

@isabelcosta Is the issue fine. Or does it need more changes?

paritoshsinghrahar avatar Sep 16 '20 00:09 paritoshsinghrahar

Hey, can you please assign this issue to me

priyanshuone6 avatar Sep 16 '20 01:09 priyanshuone6

I would like to work on this!

rubyruins avatar Sep 16 '20 04:09 rubyruins

@priyanshuone6 I'll assign it to you if you are eager. But do remember it's Status: On Hold because the scope of the issue may change. And you may need to change the whole code. It still needs approval from a Team Lead. If you aren't interested, then please inform.

paritoshsinghrahar avatar Sep 16 '20 17:09 paritoshsinghrahar

@SanketDG How do you feel about the scope of the Issue. Any additions or subtractions?

paritoshsinghrahar avatar Sep 16 '20 18:09 paritoshsinghrahar

Looks good to me, why not just rename to zulip_username.

Deprecation in reality is actually a great idea, but I feel we can easily have a breaking change here to rename.

SanketDG avatar Sep 17 '20 15:09 SanketDG

So should I depreciate slack_username or should I rename it to zulip_username?

priyanshuone6 avatar Sep 19 '20 03:09 priyanshuone6

So should I depreciate slack_username or should I rename it to zulip_username?

We will go with renaming it then to zulip_username. @priyanshuone6

paritoshsinghrahar avatar Sep 21 '20 01:09 paritoshsinghrahar

@paritoshsinghrahar Do I have to rename it to zulip_username in the whole repo?

priyanshuone6 avatar Sep 21 '20 01:09 priyanshuone6

@priyanshuone6 You can start by focusing here: https://mentorship-backend-temp.herokuapp.com/ for now.

paritoshsinghrahar avatar Sep 21 '20 03:09 paritoshsinghrahar

I would like to take up this issue.

Anmollenka avatar Mar 13 '21 04:03 Anmollenka

@paritoshsinghrahar Hey, is this issue available to be worked on? I am interested in the project. Right now, I'm trying to set it up.

SrijanShovit avatar Aug 06 '23 12:08 SrijanShovit