mentorship-backend Delete relation when the user did not create the request

Describe the bug

When a user tries to delete a relation that was not created by that user, a wrong error message is recieved.

To Reproduce

Steps to reproduce the behavior:

Login as testuserd
Delete a mentorship relation between testuserc and testuserb

This error message is recieved "This mentorship relation is not in the pending state."

Expected behavior Expected error message is - "you cannot delete a mentorship request that you did not create."

Screenshots Screenshot from 2020-08-28 13-29-05

Aug 28 '20 17:08 rpattath

Hey @rpattath I would like to work on this issue.

Aug 29 '20 07:08 divyanshugit

Hi @rpattath, is this issue taken for OSH? If not I would be happy to take that.

Sep 01 '20 10:09 dowenrei

I have assigned this to @divyanshugit @dowenrei let me know if you do not find any other issue to work. I will assign this issue to you as well.

Sep 01 '20 13:09 rpattath

@rpattath I will prefer to work on new issue and will try to find one. Ping me if there's any. Thanks

Sep 03 '20 00:09 dowenrei

if available can you pls assign it to me as i have no any other issues assigned yet

Sep 03 '20 17:09 pallavisavant

@dowenrei @pallavisavant would either of you be interested in working on this issue

Sep 03 '20 17:09 rpattath

i will go ahead pls assign it to me thanks

Sep 03 '20 17:09 pallavisavant

@pallavisavant awesome ! please comment on that issue.

Sep 03 '20 18:09 rpattath

@divyanshugit any updates ? Let me know if you are facing any issues or have any concerns.

Sep 04 '20 16:09 rpattath

Removing @divyanshugit from this issue because of no response.

Sep 07 '20 18:09 rpattath

@dowenrei would you like to work on this issue?

Sep 07 '20 18:09 rpattath

@rpattath yes sure!

Sep 07 '20 18:09 dowenrei

@rpattath I was unable to give you any updates. Because of the electricity shutdown in my area, The shutdown was caused by storm. I will look on other issues.

Sep 07 '20 21:09 divyanshugit

Hi,

I am up for this issue. I have one assigned issue which is resolved and I have created PR which is in review state.

Sep 08 '20 17:09 ashokrayal

@divyanshugit I am really sorry to hear that. Hope you find another issue soon.

@Ashokrayal please look for other issues that have Available label.

Sep 08 '20 19:09 rpattath

@dowenrei if you have created a PR make sure you use the correct formatting for the issue. If the PR is formatted correctly we will see a message like below on this issue. Screenshot from 2020-09-09 19-10-45