mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Add to List Users API the ability to filter users by skills

Open paritoshsinghrahar opened this issue 4 years ago • 38 comments

Description

As a member of the app, I need be able to filter other members by their skills, so that I can choose the member I want to create a mentorship relation with.

APIs used to fetch Users, don't have an option to filter users by skills attribute.

Note: This issue is labeled for Open Source Hack.

I can assign this issue to you on September 1st as the official opening date for Open Source Hack. Please free to check out other issues in the meantime. Program website: https://anitab-org.github.io/events/open-source-hack/

Acceptance Criteria

Update [Required]

  • [ ] Add a query parameter support to GET /users and GET /users/verified, to filter users by skills attribute.
  • [ ] Update Swagger UI documentation for this API.
  • [ ] Write at least one test to prove your new feature is working.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

[4] hours

paritoshsinghrahar avatar Aug 27 '20 13:08 paritoshsinghrahar

Hi,

I want to work on this one. please assign it to me.

ashokrayal avatar Aug 29 '20 16:08 ashokrayal

@Ashokrayal Another issue has been assigned to you. Please complete that and check back.

paritoshsinghrahar avatar Sep 01 '20 10:09 paritoshsinghrahar

Hi @paritoshsinghrahar, I'd like to work on this issue for OSH, could you please assign it to me?

Manav-03 avatar Sep 02 '20 10:09 Manav-03

@Manav-03 I have assigned you. I hope you have set up the environment and read community guidelines.

Happy Coding. :smiley:

paritoshsinghrahar avatar Sep 03 '20 10:09 paritoshsinghrahar

@paritoshsinghrahar Thank you, I'll get to it right away. :)

Manav-03 avatar Sep 03 '20 14:09 Manav-03

@Manav-03 how's the PR going?

vj-codes avatar Sep 07 '20 07:09 vj-codes

@vj-codes I had some trouble setting the environment up but I'm working on it right now :)

Manav-03 avatar Sep 07 '20 07:09 Manav-03

@Manav-03 if the errors are solved, share them here or on zulip, we could help you then:)

vj-codes avatar Sep 07 '20 08:09 vj-codes

@vj-codes I set up the environment and installed the requirements. However, when I tried to run 'run.py' it gave me some errors about not having the module pysqlite. I tried to install pysqlite but it didn't work as python 3 does not support pysqlite, it said that that I should install pysqlite3 instead, which I did, but it hasn't helped.

Manav-03 avatar Sep 07 '20 09:09 Manav-03

@Manav-03 please can you provide screenshot of - error and your .env file

vj-codes avatar Sep 07 '20 09:09 vj-codes

@vj-codes image - error image - .env

Manav-03 avatar Sep 07 '20 10:09 Manav-03

@Manav-03 secret_key should be different from security_password_salt , either update any one to 12345 Then , mail_default_sender should be an actual email like [email protected] If you are using gmail above then , mail_server is smtp.mail.com , if using something else search and adapt the mail_server accordingly app_mail_username should be username used in above mail address like in this case it is myname

Mostly the error was due to the .env file , update what I mentioned above and see if it runs

vj-codes avatar Sep 07 '20 10:09 vj-codes

@Manav-03 remove the current virtual environment and name it as venv only coz the code uses venv and may cause more errors

vj-codes avatar Sep 07 '20 10:09 vj-codes

@vj-codes image

I made these changed to .env and the problem still persists. Should I delete the virtual environment I created and create another one with the name venv?

Manav-03 avatar Sep 07 '20 10:09 Manav-03

@Manav-03 I would say yes Also do this command pip install python-dotenv before python run.py

vj-codes avatar Sep 07 '20 10:09 vj-codes

Is this still available if yes then can i take this up ..Thanks.

pallavisavant avatar Sep 08 '20 19:09 pallavisavant

@pallavisavant The issue is assigned to me. I've had some issues on my system while working on it, due to which I've been slowed down. If I can't figure it out in a few more days I will unassign myself.

Manav-03 avatar Sep 09 '20 06:09 Manav-03

@Manav-03 ok no issues....Thanks.

pallavisavant avatar Sep 09 '20 06:09 pallavisavant

@Manav-03 what do you see on your localhost now?

vj-codes avatar Sep 09 '20 07:09 vj-codes

@vj-codes Ever since I removed the environment that I first created to make another one with the appropriate name my terminal is not even recognizing 'Python', I tried to add it to the PATH variable but I'm still facing issues. I'll figure out the issues in my system ASAP and get back to it.

Manav-03 avatar Sep 09 '20 07:09 Manav-03

Hi @Manav-03 ,

Are you still working on it?

ashokrayal avatar Sep 12 '20 12:09 ashokrayal

Hi @Ashokrayal,

I've been facing a lot of issues with my system, I'll just un-assign myself.

Manav-03 avatar Sep 12 '20 13:09 Manav-03

@Manav-03 it's ok, If you want to take more time. I just wanted to know if you are still working on it.

I will be happy be help you in your issues.

ashokrayal avatar Sep 12 '20 13:09 ashokrayal

@Manav-03 it's ok, If you want to take more time. I just wanted to know if you are still working on it.

I will be happy be help you in your issues.

I also step up the project on my system recently. I just created new environment and .env file. I also commented requirements.txt file line 21-24 (docker related dependencies) and worked.

ashokrayal avatar Sep 12 '20 13:09 ashokrayal

@Ashokrayal I've tried all of that but the issue just seems to be something with my system and it's taking me a lot of time to figure it out. I think it's best if I try to figure that out instead of keeping this issue unavailable for people who could actually work on it. I'll take up another issue once I've sorted the issues with my system out :)

Manav-03 avatar Sep 12 '20 13:09 Manav-03

Hi @vj-codes / @paritoshsinghrahar ,

I would like to work on this issue. I have no issues in progress. I already asked the same on 29th Aug.

Thanks

ashokrayal avatar Sep 12 '20 18:09 ashokrayal

Assigning you @Ashokrayal Happy coding!

vj-codes avatar Sep 12 '20 19:09 vj-codes

Assigning you @Ashokrayal Happy coding!

thanks @vj-codes.

ashokrayal avatar Sep 13 '20 03:09 ashokrayal

Hi @vj-codes. Is this issue open? If it is, then I would like to work on this.

battuAshita avatar May 03 '21 13:05 battuAshita

Assigning you @battuAshita Happy coding!

vj-codes avatar May 03 '21 16:05 vj-codes