mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Replace {request_id} with {relation_id} in the Swagger UI and its related parameters

Open PrashanthPuneriya opened this issue 4 years ago • 17 comments

Describe the bug After a relationship has been formed between mentor and mentee, whenever a task is either created, edited, deleted or listed the Swagger UI should display the relationship between them as {relation_id} instead of {request_id}.

Expected behavior {relation_id} should be displayed instead of {request_id}

Screenshots image

Additional context In addition to the Swagger UI the function parameters and its corresponding variable names needs to be modified.

PrashanthPuneriya avatar Aug 16 '20 15:08 PrashanthPuneriya

@isabelcosta Can you have a look at this? I believe that it'll require a huge change in files of resources, dao, and tests cc: @PrashanthPuneriya

vj-codes avatar Aug 16 '20 19:08 vj-codes

@vj-codes @PrashanthPuneriya I think its a valid change :) Yes, it will require some big changes, but not complex ones :) Whoever takes this, can ask for help, this does not seem to change logic, just naming variables. Makes sense?

isabelcosta avatar Aug 21 '20 01:08 isabelcosta

I would like to work on this . Can you assign me this issue?

gitpurva avatar Aug 31 '20 20:08 gitpurva

Assigning you @gitpurva Happy coding!

vj-codes avatar Aug 31 '20 20:08 vj-codes

hi i would like to work on this can i

vaibhavarora102 avatar Sep 05 '20 17:09 vaibhavarora102

@gitpurva it's been 5 days and no update from your side , thus unassigning you from this issue.

vj-codes avatar Sep 05 '20 18:09 vj-codes

Assigning you @vaibhavarora102 Happy coding!

vj-codes avatar Sep 05 '20 18:09 vj-codes

@vj-codes I have already sent a PR solving the issue and it has passed all the unit test cases also. The PR is under review.

gitpurva avatar Sep 05 '20 18:09 gitpurva

@gitpurva sorry my bad , you haven't linked this issue in fixes part of your PR , show it didn't show up here . Assigning you back 🎉

vj-codes avatar Sep 05 '20 18:09 vj-codes

@vj-codes Sorry about that. I did not know about the fixing part:(

gitpurva avatar Sep 05 '20 18:09 gitpurva

@gitpurva If you are not able to link then you can unassign you from this issue. and i will make a linked pull request. @PrashanthPuneriya you can assign me this issue.

codesankalp avatar Sep 23 '20 08:09 codesankalp

It's been a long i.e. 18days and the pull request is not linked. That's why i want to work on this issue.

codesankalp avatar Sep 23 '20 08:09 codesankalp

Not linking the PR doesn't mean that the work hasn't been done. @gitpurva has almost completed the work. I was busy with my exams so I had forgotten this issue and I apologize for that @codesankalp :)

PrashanthPuneriya avatar Sep 23 '20 09:09 PrashanthPuneriya

No problem @PrashanthPuneriya . I commented because the assignee didn't respond since 18 days. :smile:

codesankalp avatar Sep 23 '20 11:09 codesankalp

I would like to work on this @devkapilbansal :)

vj-codes avatar Mar 29 '21 16:03 vj-codes

yours @vj-codes 🤗

isabelcosta avatar Apr 02 '21 12:04 isabelcosta

Didn't see that issue is already assigned :grimacing:

devkapilbansal avatar Apr 04 '21 22:04 devkapilbansal