mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Error message mismatches for entering invalid Email id for user under "Sends the user a new verification email"

Open faznan3nazer opened this issue 4 years ago • 10 comments

Describe the bug

When we enter an invalid mail id, an appropriate error message should be shown and listed under the Responses.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'user-Sends the user a new verification email'
  2. Provide the invalid email id
  3. { "email": "dssfgdsgkhu" }
  4. Click on 'Execute'.
  5. Scroll down to 'Responses'.

Screenshot (277)

Expected behavior That error message should be listed in the responses.

Desktop (please complete the following information):

  • OS: windows10
  • Browser chrome

Additional context The error message generated should match with the error message listed under responses.

faznan3nazer avatar Aug 11 '20 15:08 faznan3nazer

@isabelcosta can I take this issue?

saikirankv avatar Aug 20 '20 07:08 saikirankv

Yes @saikirankv :) Go ahead, and let us know if you have any doubt

isabelcosta avatar Aug 21 '20 01:08 isabelcosta

@isabelcosta here is my PR https://github.com/anitab-org/mentorship-backend/pull/765 tests are passing, what is the process for PR merge.

saikirankv avatar Aug 28 '20 11:08 saikirankv

@saikirankv Someone will review your PR soon

SanketDG avatar Aug 28 '20 14:08 SanketDG

I would like to work on this issue, it would be a perfect start for a beginner like me @SanketDG @isabelcosta

harshakhmk avatar Jun 10 '21 04:06 harshakhmk

@isabelcosta I think that 400 invalid input pretty much covers all such cases

epicadk avatar Jun 10 '21 04:06 epicadk

@harshakhmk you are already assigned a different issue. Please work on one issue at a time.

epicadk avatar Jun 10 '21 04:06 epicadk

@isabelcosta I think that 400 invalid input pretty much covers all such cases

Will add status available after discussing this in the open session.

epicadk avatar Jun 10 '21 04:06 epicadk

@epicadk previous issue was not clear to proceed, I got stuck in the middle, meanwhile I can work on this

harshakhmk avatar Jun 10 '21 04:06 harshakhmk

In anycase I think we need to discuss this issue in the open session before moving forward.

epicadk avatar Jun 10 '21 06:06 epicadk