mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Email verification date should be hold and returned by backend as UNIX float

Open annabauza opened this issue 5 years ago • 14 comments

Describe the bug To keep consistency we should keep and return all dates as UNIX float. Currently email_verification_date has been hold and returned as date.

To Reproduce Steps to reproduce the behavior:

  1. Get any verified user data
  2. See one date is in wrong format
  3. View data type of User table
  4. see one date is not a float type

Expected behavior All dates stored and returned by backend should be UNIX floats

Screenshots Screenshot 2020-02-15 at 19 36 30 image (2)

annabauza avatar Feb 16 '20 21:02 annabauza

@isabelcosta Can I work on this issue?

srivastava9 avatar Feb 22 '20 19:02 srivastava9

@srivastava9 since you already worked on a First Timers Only issue, can you please find another issue to solve? In this way, this issue can be solved by a newcomer :)

isabelcosta avatar Feb 22 '20 22:02 isabelcosta

Okay Cool ,Haven't seen the first timers label.

srivastava9 avatar Feb 22 '20 22:02 srivastava9

no problem at all @srivastava9 :)

isabelcosta avatar Feb 22 '20 22:02 isabelcosta

@isabelcosta can I work on this issue?

dubesar avatar Feb 25 '20 14:02 dubesar

@dubesar sure you can :)

isabelcosta avatar Feb 25 '20 18:02 isabelcosta

@isabelcosta can i take up this issue?

SanujBansal avatar Feb 26 '20 20:02 SanujBansal

@dubesar are you going to work on this? If yes, I can wait for your submission, if not let us know so other contributors can work on it. cc @SanujBansal

isabelcosta avatar Feb 27 '20 23:02 isabelcosta

@isabelcosta I am not able to give time. It's okay if somebody wants to work on it.

dubesar avatar Feb 28 '20 03:02 dubesar

No problem at all! You can help on other issues later if you want to :) Thank you so much for letting us know @dubesar. I really do appreciate it 🙌

isabelcosta avatar Feb 28 '20 12:02 isabelcosta

@isabelcosta Thank you for letting me work on this as my first contribution. Please check the PR #460 linked to this issue.

SanujBansal avatar Mar 01 '20 06:03 SanujBansal

Hi is this issue still open? Can you please help me with resolving the bug since I am new?

eleensmathew avatar Feb 14 '22 12:02 eleensmathew

not sure why we need to return this field in the first place.

cc @isabelcosta

epicadk avatar Feb 14 '22 12:02 epicadk

can i work on this issue

octonawish-akcodes avatar Feb 22 '22 10:02 octonawish-akcodes