mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Search and filtering for endpoints

Open bartekpacia opened this issue 5 years ago • 8 comments

Is your feature request related to a problem? I was making a write-up about best REST practices and something essential came to my mind. A functionality so common that it's surprising we don't have it - search.

Describe the solution you'd like I'd like features listed above to be supported in all endpoints (if applicable). It could be done using BaseModel.filter() method that Flask-SQLAlchemy provides.

Search URL examples

/users?username=john /users?location=us /mentorship_relation/{request_id}/tasks?title=learn_react

Describe alternatives you've considered We can do all this stuff on the client side and considering current scale of the project, it's not really a big deal. However, serious problems will arise if the number of users (or data in general) gets increased.

bartekpacia avatar Dec 19 '19 22:12 bartekpacia

Thank you @NenadPantelic for bringing this to our attention and @devkapilbansal for confirming it! as you said on Zulip, these are the issues related:

  • https://github.com/anitab-org/mentorship-backend/issues/403
  • https://github.com/anitab-org/mentorship-backend/issues/420
  • https://github.com/anitab-org/mentorship-backend/issues/759
  • https://github.com/anitab-org/mentorship-backend/issues/760

isabelcosta avatar Feb 23 '21 20:02 isabelcosta

No prob, can I take this in that case? :smile:

NenadPantelic avatar Feb 24 '21 13:02 NenadPantelic

Sure @NenadPantelic

devkapilbansal avatar Feb 24 '21 13:02 devkapilbansal

Can I take up this issue in case of not completed

b-thebest avatar Mar 02 '21 12:03 b-thebest

I'm working on it, was a bit busy with some private things these days

NenadPantelic avatar Mar 02 '21 13:03 NenadPantelic

I was occupied with other issues these days, hope to the PR in next two days.

NenadPantelic avatar Mar 07 '21 11:03 NenadPantelic

@NenadPantelic any updates? If there's no response from @NenadPantelic , @b-thebest are you still interested to work on this?

vj-codes avatar Mar 30 '21 08:03 vj-codes

Hey @vj-codes. Sorry, my timetable is full, I have a lot of things I'm working on at the moment. If @b-thebest or someone else is willing to, go ahead, the issue is yours. I'll ping you when I got some time if the issue is not solved at that point.

NenadPantelic avatar Mar 31 '21 09:03 NenadPantelic