mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Require mentor's approval for task completion

Open bartekpacia opened this issue 5 years ago • 7 comments

Is your feature request related to a problem? Please describe. This was first raised by asawesome07 in this PR. What he suggests is adding a new feature: in a specific mentorship relatio, the user can't mark the task as completed himself - he needs the mettor's approval.

Describe the solution you'd like I think the best solution is to add a new property to relation data model. This property would indentify whether mentee can mark tasks as completed by himself or needs a mentor to approve task completion.

This property could be named [for example] requires_approval: [boolean]

It would default to false when the relation is created. After that, only mentor would be able to change it.

Describe alternatives you've considered I think the above is the simplest solution, but there might be a better one I'm not aware of.

bartekpacia avatar Dec 15 '19 02:12 bartekpacia

Good idea @bartekpacia 🎉 I think that has crossed my mind during the GSoC program, but for the sake of having a minimum functional product, I think we decided to simplify there. This is a great idea to think now :)

There could be something added to the task model. Here's what is exposed by the API:

{
  "id": 0,
  "description": "string",
  "is_done": true,
  "created_at": 0,
  "completed_at": 0
}

To facilitate brainstorming this issue

isabelcosta avatar Dec 15 '19 14:12 isabelcosta

Great, I'll try to look into in when I finish implementing CLI :)

bartekpacia avatar Dec 15 '19 17:12 bartekpacia

Aaaand...done:D

bartekpacia avatar Dec 17 '19 16:12 bartekpacia

Is this issue resolved?

vermastuti avatar Sep 25 '20 18:09 vermastuti

I did it long time ago in #292, but can't bring that branch up to date with master right now

bartekpacia avatar Feb 21 '21 22:02 bartekpacia

@vj-codes can I work on this?

RiddhiAthreya avatar Jul 01 '21 13:07 RiddhiAthreya

Assigning you @RiddhiAthreya Happy coding!

vj-codes avatar Jul 02 '21 17:07 vj-codes