mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Fix error status code and written unittests for Resend Email

Open harshakhmk opened this issue 3 years ago • 7 comments

Description

Fixed status code, error responses for Resend Email endpoint and written unit tests

Fixes # 625

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged
  • [ ] Update Postman API at /docs folder
  • [x] Update Swagger documentation and the exported file at /docs folder
  • [ ] Update requirements.txt

Code/Quality Assurance Only

  • [x] My changes generate no new warnings
  • [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been published in downstream modules

harshakhmk avatar Jun 20 '21 05:06 harshakhmk

Hello there!👋 Welcome to the project!💖 Thank you and congrats 🎉 for opening your first PR on this project.✨ Please ensure your Pull Request meets the Commit Message Style Guide. We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities. Hope you have a great time here :)

welcome[bot] avatar Jun 20 '21 05:06 welcome[bot]

@isabelcosta @vj-codes @devkapilbansal I have raised an MR kindly review it, let me know if there any changes

harshakhmk avatar Jun 20 '21 05:06 harshakhmk

@devkapilbansal updated the code

harshakhmk avatar Jun 20 '21 07:06 harshakhmk

I have updated the commit @devkapilbansal @isabelcosta

harshakhmk avatar Jul 03 '21 11:07 harshakhmk

@devkapilbansal thank you for pinging me for this 🙏🏾 And great work reviewing PR!

isabelcosta avatar Jul 03 '21 18:07 isabelcosta

@harshakhmk tests are failing. Please fix them and update the code.

devkapilbansal avatar Jul 15 '21 20:07 devkapilbansal

@harshakhmk any updates about this PR?

vj-codes avatar Jul 24 '21 13:07 vj-codes