mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

test: Create user journey for request deletion

Open decon-harsh opened this issue 5 years ago • 5 comments

Description

This patch creates a user journey test depicting the process of sending a new mentorship request by a mentee to a mentor. The mentee then deletes the request sent.

Fixes #911

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Screenshot from 2021-02-18 21-32-34

Checklist:

  • [X] My PR follows the style guidelines of this project
  • [X] I have performed a self-review of my own code or materials
  • [X] I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • [X] My changes generate no new warnings
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes

decon-harsh avatar Feb 18 '21 16:02 decon-harsh

Codecov Report

Merging #1007 (8463aa5) into develop (1765e56) will increase coverage by 0.01%. The diff coverage is 97.82%.

:exclamation: Current head 8463aa5 differs from pull request most recent head 893fa5d. Consider uploading reports for the commit 893fa5d to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    96.16%   96.18%   +0.01%     
===========================================
  Files          100      101       +1     
  Lines         5429     5475      +46     
===========================================
+ Hits          5221     5266      +45     
- Misses         208      209       +1     
Impacted Files Coverage Δ
tests/user_journey/test_request_deletion_path.py 97.82% <97.82%> (ø)

codecov[bot] avatar Feb 18 '21 16:02 codecov[bot]

Sorry Unapprove, I meant changes requested.

epicadk avatar Apr 09 '21 11:04 epicadk

@decon-harsh any updates here?

vj-codes avatar May 05 '21 17:05 vj-codes

@decon-harsh ^ ?

vj-codes avatar May 18 '21 15:05 vj-codes

@decon-harsh ^ ?

Hi I think you missed the update on zulip. As long as this isn't blocking please leave this pr open.

epicadk avatar May 18 '21 17:05 epicadk