mentorship-backend icon indicating copy to clipboard operation
mentorship-backend copied to clipboard

Bump flask jwt extended version to 4.0.2 #1002

Open epicadk opened this issue 5 years ago • 11 comments

Description

Bump flask jwt extended version to 4.0.2 Fixes #1002

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Ran existing unit tests

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] Update requirements.txt

Code/Quality Assurance Only

  • [ ] My changes generate no new warnings
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been published in downstream modules

epicadk avatar Feb 17 '21 16:02 epicadk

Codecov Report

Merging #1005 (f7bc61a) into develop (c154317) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1005   +/-   ##
========================================
  Coverage    93.25%   93.25%           
========================================
  Files           38       38           
  Lines         2062     2062           
========================================
  Hits          1923     1923           
  Misses         139      139           
Impacted Files Coverage Δ
app/api/jwt_extension.py 100.00% <100.00%> (ø)
app/api/resources/admin.py 88.70% <100.00%> (ø)
app/api/resources/mentorship_relation.py 97.07% <100.00%> (ø)
app/api/resources/task.py 100.00% <100.00%> (ø)
app/api/resources/task_comment.py 100.00% <100.00%> (ø)
app/api/resources/user.py 90.36% <100.00%> (ø)

codecov[bot] avatar Feb 17 '21 16:02 codecov[bot]

Not sure why, but when I tried to deploy this to Heroku Review App is giving 500 Internal Server Error :O https://ms-backend-review-pr-1005.herokuapp.com/ cc @epicadk @devkapilbansal I have no idea why 🤔 and why tests pass and this fails

isabelcosta avatar Apr 02 '21 12:04 isabelcosta

@isabelcosta may I know these environment variables on heroku

DB_TYPE
DB_USERNAME
DB_PASSWORD
DB_ENDPOINT
DB_NAME

devkapilbansal avatar Apr 02 '21 13:04 devkapilbansal

P.S.:- Changing DB_TYPE to postgresql should solve the issue

devkapilbansal avatar Apr 02 '21 13:04 devkapilbansal

@isabelcosta may I know these environment variables on heroku

DB_TYPE
DB_USERNAME
DB_PASSWORD
DB_ENDPOINT
DB_NAME

Yes, it's something like this:

DB_TYPE='postgres'
DB_USERNAME='XXXXX'
DB_PASSWORD='XXXXXXXXXXXXXXXXXXXXXXX'
DB_ENDPOINT='drona.db.elephantsql.com:5432'
DB_NAME='qieoopii'

@devkapilbansal same as the deployed server db

isabelcosta avatar Apr 02 '21 14:04 isabelcosta

Looking into this. It's working fine for me. But I did have to run pip install -Ur requirements.txt

epicadk avatar Apr 02 '21 14:04 epicadk

Looking into this. It's working fine for me. But I did have to run pip install -Ur requirements.txt

Probably we need to update some other dependencies too

devkapilbansal avatar Apr 03 '21 09:04 devkapilbansal

Adding it to TODO. Will search for the root cause soon

devkapilbansal avatar Apr 07 '21 17:04 devkapilbansal

@isabelcosta can you share the log ?

epicadk avatar Apr 07 '21 17:04 epicadk

@isabelcosta can you please test it again

devkapilbansal avatar Jul 03 '21 12:07 devkapilbansal

:( I keep seeing the 500 error

internal server error

I just used a review app from another PR, and it worked fine. Also on heroku, I can't seem to understand how to check the logs for Review Apps. :(

I will check this later again

isabelcosta avatar Jul 29 '21 22:07 isabelcosta