mentorship-android icon indicating copy to clipboard operation
mentorship-android copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Replace any hard-coded strings present in the application

Open sanchi0204 opened this issue 4 years ago • 24 comments

Description Application contains hard-coded strings in many files.

Expected behavior Hard-coded strings must be fixed via proper replacement with the strings in strings.xml file. This will make it easier to have app localization in different languages in the future.

sanchi0204 avatar Aug 23 '20 10:08 sanchi0204

@sanchi0204 Hey, it would be great if you could also provide an example just to make it easier

anna4j avatar Aug 23 '20 17:08 anna4j

Looking forward to working on this by 1st!

Sommie09 avatar Aug 25 '20 07:08 Sommie09

@Sommie09 You can be assigned to only one issue at a time, So I think you should make up your mind about which issue you want to work on :)

anna4j avatar Aug 25 '20 11:08 anna4j

@anna4j My bad!, this first. Then others from another category :)

Sommie09 avatar Aug 25 '20 11:08 Sommie09

@Sommie09 Assigning you, send in your PR after 1st. Happy coding :)

anna4j avatar Aug 25 '20 11:08 anna4j

Thank you! Would work on it right away

Sommie09 avatar Aug 25 '20 11:08 Sommie09

DONE! Would be sending my PR in a few hours @anna4j

Sommie09 avatar Aug 31 '20 17:08 Sommie09

I would like to work on this issue as a part of OSH. Can you assign me this issue? Thank You.

Abjcodes avatar Aug 31 '20 18:08 Abjcodes

Sorry @Abjcodes It was assigned to me, and I've sent in a PR

Sommie09 avatar Aug 31 '20 18:08 Sommie09

@Sommie09 can't see your PR

anna4j avatar Aug 31 '20 19:08 anna4j

It's been sent @anna4j

Sommie09 avatar Aug 31 '20 19:08 Sommie09

Okay awesome! @Sommie09

anna4j avatar Aug 31 '20 19:08 anna4j

Great! @anna4j I'll be waiting for a merge

Sommie09 avatar Aug 31 '20 19:08 Sommie09

Hello @sanchi0204 when could I send a PR for my other issue?

Sommie09 avatar Sep 01 '20 13:09 Sommie09

Hello @sanchi0204 when could I send a PR for my other issue?

Could you pls link the issue you are referencing to

sanchi0204 avatar Sep 01 '20 13:09 sanchi0204

#751 , When am I free to send a PR for this?

Sommie09 avatar Sep 01 '20 13:09 Sommie09

#751 , When am I free to send a PR for this?

You can send it whenever you're done solving it

anna4j avatar Sep 01 '20 13:09 anna4j

Is the issue valid still @isabelcosta ? There are some hardcoded strings present in some files like LoginActivity.kt , SignUpActivity.kt, FeedbackActivity.kt, SendRequestActivity.kt and some others. I would like to work on it.

ahk4815 avatar Jan 22 '21 16:01 ahk4815

@ahk4815 yes it is, I will assign it to you then :)

isabelcosta avatar Jan 24 '21 02:01 isabelcosta

Hi @isabelcosta Is this issue workable ?

bosankus avatar Oct 12 '21 07:10 bosankus

On it ⚡

bosankus avatar Oct 13 '21 04:10 bosankus

Hi @isabelcosta @epicadk I have opened a PR. Can you kindly review. Please let me know if I missed out something. Thanks.

bosankus avatar Oct 13 '21 08:10 bosankus

@epicadk added commit. Ran spotless. Only getting one issue in SendRequestActivity.kt on line 11: import kotlinx.android.synthetic.main.activity_send_request.*

Auto importing on any view adds this line.

bosankus avatar Oct 15 '21 12:10 bosankus

Hi @isabelcosta , can you kindly approve the PR. Actually I want to start with another issue. Can't until this gets green. Thanks.

bosankus avatar Oct 26 '21 04:10 bosankus