mentorship-android
mentorship-android copied to clipboard
anitab-org
Set off screen page limit in Viewpager
Describe the bug The requests page uses a Viewpager to show the pending, past and all requests. The current app does not set off screen page limit.
To Reproduce Steps to reproduce the behavior:
- Go to Request page
Expected behavior The request page should have a screen page limit
Additional context Offscreenpagelimit should be set in this case as we have just three pages and all of them can be kept active at once. This would save time in data fetching as there will be less time spent to create the new views as the user goes back and forth.
Makes sense to me, we can do some major refactoring here. Can you use the ViewPager2 library to implement this. The offScreenPageLimit can be set to 2.
But before that please follow the issue template and update the description
@m-murad Yes I think migrating to ViewPager2 would be good as it is adds enhanced functoinalities.
How do you think I should proceed?
I will update the issue description.
Update the issue description. Replace ViewPager with ViewPager2 in the project.
@m-murad I think there is an issue for migrating to ViewPager2. What should be done in that case?
@m-murad Sorry for inactivity I will try to send a PR till this weekend
@epicadk @vj-codes in issue #755 i've migrated viewPager to viewPager2 so is this issue still available to be worked upon ? If yes i would love to take it up :-)
@epicadk @vj-codes in issue #755 i've migrated viewPager to viewPager2 so is this issue still available to be worked upon ? If yes i would love to take it up :-)
This can be put on hold till the Viewpager2 pr is merged.
@epicadk @vj-codes in issue #755 i've migrated viewPager to viewPager2 so is this issue still available to be worked upon ? If yes i would love to take it up :-)
This can be put on hold till the Viewpager2 pr is merged.
hmm ok.
Can i work on this
This issue is on hold. Please find one that is marked as status available.