mentorship-android icon indicating copy to clipboard operation
mentorship-android copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

enable data binding in ChangePasswordFragment

Open jddeep opened this issue 4 years ago • 11 comments

enable data binding in ChangePasswordFragment. Since we are following the MVVM arch. we need to declare the layout as the former so that we can use its features(Binding Adapters,etc.)

Additional context Following MVVM architecture for our app.

jddeep avatar Mar 03 '20 16:03 jddeep

@m-murad @annabauza Please have a look. May I go ahead with this?

jddeep avatar Mar 03 '20 16:03 jddeep

I don't think we need a DataBinding in this fragment. DataBinding is used when we need to display some data or react to continuous change of multiple feilds.

m-murad avatar Mar 03 '20 16:03 m-murad

@m-murad But in PR #598 I was suggested of using BindingAdapters :thought_balloon:

jddeep avatar Mar 03 '20 16:03 jddeep

I didn't suggest it, I guess we should discuss this on zulip

m-murad avatar Mar 03 '20 16:03 m-murad

Okay

jddeep avatar Mar 03 '20 16:03 jddeep

I guess using DataBinding here would be an engineering overkill, not needed.

m-murad avatar Mar 03 '20 17:03 m-murad

Agreed. Let's see what @annabauza has thoughts about this :)

jddeep avatar Mar 03 '20 17:03 jddeep

I'll leave the decision to @isabelcosta as she is the maintainer.

annabauza avatar Mar 04 '20 11:03 annabauza

@isabelcosta Thoughts on this please.

jddeep avatar Mar 09 '20 12:03 jddeep

@vj-codes is this a valid issue? Or should it be closed?

anna4j avatar Aug 22 '20 08:08 anna4j

Can i work on this issue !

kartikeysaran avatar Mar 01 '21 09:03 kartikeysaran