mentorship-android icon indicating copy to clipboard operation
mentorship-android copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Save login credentials using Credentials API

Open isabelcosta opened this issue 4 years ago • 18 comments

Description

taken from a Google Code in task

When a user logs in, the credentials are not saved. If the user has to reinstall the app, they have to type the credentials again.

Acceptance Criteria

Update [Required]

  • [ ] Integrate "Smart Lock for Passwords" to save the user credentials.

Definition of Done

  • [ ] All of the required items are completed.
  • [x] Approval by 1 mentor.

Estimation

N/A hours

isabelcosta avatar Feb 25 '20 23:02 isabelcosta

Please assign this task to me, till now I didn't get any assigned task.

Sunil16202 avatar Mar 05 '20 07:03 Sunil16202

i am working on this issue .

ranaaditya avatar Mar 07 '20 06:03 ranaaditya

Is anyone still working on this issue? If not, please assign to me.

gaurivn avatar Apr 02 '20 10:04 gaurivn

Do you still want to work on this, @gaurivn?

MariamKotob avatar Jun 21 '20 04:06 MariamKotob

Do you still want to work on this, @gaurivn?

@MariamKotob yes, I would like to work on it.

gaurivn avatar Jun 21 '20 06:06 gaurivn

@gaurivn assigned. Enjoy it.

MariamKotob avatar Jun 21 '20 08:06 MariamKotob

Thank you :)

gaurivn avatar Jun 21 '20 08:06 gaurivn

I'm working on it, will send a PR soon.

gaurivn avatar Jul 06 '20 17:07 gaurivn

I don't have enough bandwidth to complete atm so making it available.

gaurivn avatar Jul 14 '20 16:07 gaurivn

please assign this work to me

abhishekrawe avatar Sep 02 '20 19:09 abhishekrawe

@isabelcosta @anna4j @MariamKotob Can I work on this issue ?

justdvnsh avatar Sep 12 '20 12:09 justdvnsh

Just assigned you to a different issue

anna4j avatar Sep 12 '20 13:09 anna4j

@anna4j . That issue is currently on hold. For the time being can I work on this issue ?

justdvnsh avatar Sep 16 '20 08:09 justdvnsh

Okay sure. Could you link that issue here so I can see the progress of that issue in our discussion meeting

anna4j avatar Sep 16 '20 09:09 anna4j

@isabelcosta @iofall. Just for clarification, do I need to just store the credentials or like also give users the ability to login without entering the credentials. Something like this https://drive.google.com/file/d/1U9k5MbmLb0tlgu9TvBlB0--8VlwbiezD/view?usp=drivesdk

justdvnsh avatar Sep 20 '20 18:09 justdvnsh

@isabelcosta @iofall. Just for clarification, do I need to just store the credentials or like also give users the ability to login without entering the credentials. Something like this https://drive.google.com/file/d/1U9k5MbmLb0tlgu9TvBlB0--8VlwbiezD/view?usp=drivesdk

Yes, I think this is exactly what we need. These credentials will still be saved if I uninstall the app right? So that I can use them on the next install?

iofall avatar Sep 21 '20 13:09 iofall

@iofall . Yes. The credentials would remain saved even when the user uninstall the app. https://drive.google.com/file/d/1XARDVyENA27uk3V_E_Qb5ZAl3jqLbVmS/view?usp=sharing Here is the link to the working video. Also, have created a PR

justdvnsh avatar Sep 24 '20 14:09 justdvnsh

Closing because it's not a priority now and explained here https://github.com/anitab-org/mentorship-android/pull/969#issuecomment-850832298

Will add a label for possible future feature

isabelcosta avatar May 29 '21 13:05 isabelcosta