mentorship-android icon indicating copy to clipboard operation
mentorship-android copied to clipboard

Remove AndroidJUnit4 in instrumentation tests

Open daksha-aeer opened this issue 5 years ago • 7 comments

Is your feature request related to a problem? Please describe. The android project has a few instrumentation tests to see if Sign Up and Login work. While looking at the code I encountered this message that 'AndroidJUnit4' is deprecated.

image

In fact I found out that the tests run properly if the highlighted line is removed. There's no need to import any additional library. I will be adding a pull request related to this issue as well.

Describe the solution you'd like Remove the below line along with its import statements in LoginActivityTest.kt and SignUpActivityTest.kt

@RunWith(AndroidJUnit4::class)

Describe alternatives you've considered Leave the code as it is. This works but warnings remain.

Additional context None

daksha-aeer avatar Dec 18 '19 06:12 daksha-aeer

@anitab-org/mentorship-managers can someone check the availability of this issue? If available please approve and assign to @daksha-aeer, else just close it. Thanks!

MariamKotob avatar Jun 21 '20 07:06 MariamKotob

can I work on the issue during OSH as the signupActivity still shows the deprecation message. @claim

BirajGupta avatar Aug 25 '20 17:08 BirajGupta

can I work on the issue during OSH as the signupActivity still shows the deprecation message. @claim

OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution and please tag project managers to claim issue.

aditmehta9 avatar Aug 29 '20 12:08 aditmehta9

@aditmehta9 sure i'll take care of that next time....thanks

BirajGupta avatar Aug 30 '20 16:08 BirajGupta

@aditmehta9 hey, I've made a PR regarding this issue making the relevant changes.Please review:)

BirajGupta avatar Sep 02 '20 06:09 BirajGupta

@aditmehta9 hey, I've made a PR regarding this issue making the relevant changes.Please review:)

Thanks, this PR will be reviewed by coding team and QA team. It will be merged at the end of Sept.

aditmehta9 avatar Sep 02 '20 06:09 aditmehta9

@aditmehta9 Sure. Thanks

BirajGupta avatar Sep 02 '20 06:09 BirajGupta