mentorship-android
mentorship-android copied to clipboard
Remove AndroidJUnit4 in instrumentation tests
Is your feature request related to a problem? Please describe. The android project has a few instrumentation tests to see if Sign Up and Login work. While looking at the code I encountered this message that 'AndroidJUnit4' is deprecated.
In fact I found out that the tests run properly if the highlighted line is removed. There's no need to import any additional library. I will be adding a pull request related to this issue as well.
Describe the solution you'd like Remove the below line along with its import statements in LoginActivityTest.kt and SignUpActivityTest.kt
@RunWith(AndroidJUnit4::class)
Describe alternatives you've considered Leave the code as it is. This works but warnings remain.
Additional context None
@anitab-org/mentorship-managers can someone check the availability of this issue? If available please approve and assign to @daksha-aeer, else just close it. Thanks!
can I work on the issue during OSH as the signupActivity still shows the deprecation message. @claim
can I work on the issue during OSH as the signupActivity still shows the deprecation message. @claim
OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution and please tag project managers to claim issue.
@aditmehta9 sure i'll take care of that next time....thanks
@aditmehta9 hey, I've made a PR regarding this issue making the relevant changes.Please review:)
@aditmehta9 hey, I've made a PR regarding this issue making the relevant changes.Please review:)
Thanks, this PR will be reviewed by coding team and QA team. It will be merged at the end of Sept.
@aditmehta9 Sure. Thanks