mentorship-android
mentorship-android copied to clipboard
anitab-org
Provide UI solution to show tasks from past relations
Description
As a user, I need know the history of my past mentorship relations, so that I can understand my past accomplishments and how they relate to my past relations.
Would be nice to see the tasks related to the past mentorship relations. There can be a lot of ways to show this. Options I thought of:
- show tasks specific to a mentorship relation on the Mentorship Relation screen, that comes from the mentorship relations/requests lists screen.
- provide another screen that shows all tasks and relating each to a specific relation (Tasks History screen).
Before implementing this there should be some discussions and mock up designs provided and approved by the community.
Mocks
This is what I want
Acceptance Criteria
Update [Required]
- [ ] Provide a user interface solution to where and how to show the tasks of past mentorship relations, taking into account a good user experience and the existing interface.
Definition of Done
- [ ] All of the required items are completed.
- [ ] Approval by 1 mentor.
Estimation
5 hours
@isabelcosta When i send request it show mentorship relation minimum duration is 4 week . I cant send request? Also can i work on this issue.
yeah @ak8527 it should be minimum 4 duration week o, you have to put the relation more than four weeks and if the person is already on relationship with others then also you cannot send the request to him
@mohak1283 I don't remember when you did the PR to set a minimum to the calendar for the end dat of a mentorship relation, did you count the 4 weeks? Could this be an edge case because of February month days count?
@ak8527 can you address my request changes on 2 of your PRs before looking into other issues?
Ups thank you @mohak1283 ;)
@mohak1283 I don't remember when you did the PR to set a minimum to the calendar for the end dat of a mentorship relation, did you count the 4 weeks? Could this be an edge case because of February month days count?
@Manik1094 do you remember this?
This can be seen through the code (its open sourced 😝 ), but I'm focusing now on answering comments on PRs and issues, if anyone can take a look at this, and if it is a bug, I would appreciate a lot!
A figma url added to an md file. The md file should be under docs/ui. @isabelcosta correct me if I am wrong.
Umm, I have to create that directory as a PR right?
On Tue, Sep 8, 2020 at 9:53 PM Roshni Pattath [email protected] wrote:
A figma url added to an md file. The md file should be under docs/ui. @isabelcosta https://github.com/isabelcosta correct me if I am wrong.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/mentorship-android/issues/157#issuecomment-688990278, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALE6VIHVHHYT6UXWQ6YLTQTSEZLAHANCNFSM4GUIKFKQ .
ok
On Tue, Sep 8, 2020 at 10:04 PM Roshni Pattath [email protected] wrote:
yes
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/mentorship-android/issues/157#issuecomment-688996854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALE6VIGSKYSJ2VAEKEWWTVTSEZMKBANCNFSM4GUIKFKQ .
@rpattath Please review and tell me the changes needed, as I have done a very simple solution.
@alivabasa you have created a PR under your fork and not under anitab-org. Also make sure design is cohesive with the existing design of the app.
@rpattath Ok. The existing design of the app means the screenshots provided ?
A figma url added to an md file. The md file should be under docs/ui. @isabelcosta correct me if I am wrong.
Sorry for late reply @rpattath . Yes, that folder name is accurate.
@rpattath Sorry for the delay, actually my college exams were going on. I will create a new PR tomorrow. But can u tell me that, whether the design should match with the UI designs linked in Readme.md or the App's screenshot ?
Screenshots in the README is what you should follow. Preferrably remove Systers Opensource and only keep AnitaB.org logo. You can try to run the apk on an Android device to get the real feel of the current UI.
@rpattath I have submitted . The link is https://github.com/anitab-org/mentorship-android/pull/939. Please review.