mentorship-android
mentorship-android copied to clipboard
1166: Migration to Paging3 for MembersFragment
Description
- Currently the app is using a custom endless recycler view listener, which is replaced by Android Jetpack Paging 3 in this PR. The benefits are added below in a image as per the source

Fixes #1166
Type of Change:
-
Room
andPaging 3
dependencies added. - Version upgrades were done on
kotlin
to support room & paging 3. - Methods added/altered in
UserDataManager
to get paged data from room handled by new classUserRemoteMediator
. -
FilterActivity
removed as now filtering is done viaExtendedFloatingActionButton
onClick. See details here. - Previous implementation of paging data is removed, which won't be used after using paging3.
- New
BindingUtil
added for showing data on UI inlist_member_item.xml
. - Few spotless changes were done using command
./gradlew sA
. - Few
TAG
s were removed which had no use and warning came during commit.
Code/Quality Assurance Only
- New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?
- This is a draft PR and yet to be tested.
Checklist:
- [x] My PR follows the style guidelines of this project
- [x] I have performed a self-review of my own code or materials
- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
Code/Quality Assurance Only
- [x] My changes generate no new warnings
- [x] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The existing filter feature on member list was not working, and after implementinig paging3 , it is found that there is a issue with sorting and filtering the list. Refer here : https://issuetracker.google.com/issues/175430431. I am trying work around for this filtering feature at this moment, which will solve this issue.
@vj-codes @isabelcosta Two points I would like to raise: Please review this and this PR kindly.
-
The existing filter feature on member list was not working, and after implementinig paging3 , it is found that there is a issue with sorting the paged list. Refer to the issue raised here please : https://issuetracker.google.com/issues/175430431.
-
Filtering list as per skills, interest & location will be moved to changes made on Member search fragment.
Please share feedback on this
@vj-codes A check is failing, however I am unable to understand what change to do. It's regarding collision of two kotlin-stdlib versions, but i removed the dependency since its deprecated. Still the same.
Hi @isabelcosta @vj-codes Can you please review ?