refactor: replace hardcoded strings

[bosankus]

Description

Replaced hardcoded strings with the strings in string.xml. Those from test classes, constants are left unchanged.

Fixes #757

Type of Change:

• Code
• Quality Assurance

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Code was analyzed using option "Run inspection by name" with both the options: Hardcoded texts & Hardcoded strings.

Checklist:

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] Any dependent changes have been merged

Code/Quality Assurance Only

• [x] My changes generate no new warnings
• [x] New and existing unit tests pass locally with my changes

[bosankus]

pushed fixed commit, except the spotless check on the activity. I did not made any changes there.

[epicadk]

@isabelcosta please approve the workflow run.

[epicadk]

pushed fixed commit, except the spotless check on the activity. I did not made any changes there.

Are you sure you've pushed it? I can only see the two commits from earlier.

[bosankus]

Yes I have checked, the push got rejected. Working on it.

[bosankus]

@epicadk Pushed a commit. Can you check and suggest?

[bosankus]

@epicadk Can you check once?

[bosankus]

@isabelcosta can this be merged?

[bosankus]

@vj-codes @devkapilbansal

[epicadk]

@epicadk Can you check once?

Waiting for isabel to approve workflow. However I still see some wildcard imports so the spotless check could fail.

[isabelcosta]

@bosankus could you please address the merge conflicts? It should be a straightforward resolution. It's because of a recent merge that involved changing package names.

[bosankus]

@epicadk @isabelcosta Can you check the latest commit kindly ?

[epicadk]

Also the spotless check is failing please run spotless using ./gradlew spotlessApply

[bosankus]

@epicadk @isabelcosta All checks are passed in the recent commit I pushed. Can it be merged?

[bosankus]

@isabelcosta Can you kindly give review?

[bosankus]

@isabelcosta quotes removed and changes done. Waiting for your approval.

[isabelcosta]

It would be amazing if anyone could test this PR - by testing, I mean downloading the apk for this PR and making sure there are no weird behaviors coming out of this. Testing out areas where these strings that were refactored affect it.

[bosankus]

@isabelcosta I can do the testing the way you said. Can you provide the testing credentials to enter the app? Or do I need to register?

[bosankus]

Also can I move to other issues? @isabelcosta @isabelcosta

[isabelcosta]

@bosankus you can move to other issues. Usually, we prefer someone other than the author of the issue to do the testing.

For whoever tests this, the credentials are shared on zulip here: https://anitab-org.zulipchat.com/#narrow/stream/223071-newcomers/topic/Questions/near/258734796

[bosankus]

@bosankus you can move to other issues. Usually, we prefer someone other than the author of the issue to do the testing.

For whoever tests this, the credentials are shared on zulip here: https://anitab-org.zulipchat.com/#narrow/stream/223071-newcomers/topic/Questions/near/258734796

Thanks.. Copy that.

[bosankus]

@devkapilbansal & @vj-codes Can you kindly approve?

[vj-codes]

@bosankus I'll test it soon and add my review 🚀