mentorship-android
mentorship-android copied to clipboard
anitab-org
Feat #419: Added NetworkStateReceiver
Description
Added NetworkStateReceiver to the app that will notify the ViewModel when there is an internet connection and it will refresh / try to load data automatically whenever the user connects back to the internet. Earlier the user had to switch the tab in order for the app to detect connectivity and the page to be reloaded.
Fixes #419
Type of Change:
- Code
Code/Quality Assurance Only
- New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?
On 2 different emulators and a physical device Samsung galaxy J-6
Demo
https://drive.google.com/file/d/1TjmGAXnATWL8Mc2UNgPVpGhsjlj9b11n/view?usp=sharing
Checklist:
- [x] My PR follows the style guidelines of this project
- [x] I have performed a self-review of my own code or materials
Code/Quality Assurance Only
- [x] My changes generate no new warnings
Can you upload the video to github as opposed to google drive please?
it's larger than 10mb so i am not able to do so
I think before we do this, we should discuss this a little more. Because this is also a UX issues. This will make the app make extra server requests, maybe when the user is not interested in that, so perhaps instead of this being an automatic action this could be prompted by the user instead.
I am thinking about how to use the network effectively, and also with https://developer.android.com/docs/quality-guidelines/build-for-billions in mind (thank you @epicadk )
Thank you for your work in this PR @CodeChamp-SS Will postpone this, in priority of other issues of the roadmap.
cc @anitab-org/mentorship-maintainers
I think before we do this, we should discuss this a little more. Because this is also a UX issues. This will make the app make extra server requests, maybe when the user is not interested in that, so perhaps instead of this being an automatic action this could be prompted by the user instead.
I am thinking about how to use the network effectively, and also with https://developer.android.com/docs/quality-guidelines/build-for-billions in mind (thank you @epicadk )
Thank you for your work in this PR @CodeChamp-SS Will postpone this, in priority of other issues of the roadmap.
cc @anitab-org/mentorship-maintainers
maybe we can use room for caching the data instead of making extra server requests 🤔, what do you think @isabelcosta @epicadk ?