mentorship-android icon indicating copy to clipboard operation
mentorship-android copied to clipboard

Docs : Why use MVVM architecture missing

Open Sanika1999 opened this issue 4 years ago • 29 comments

Describe the bug The why use MVVM architecture is missing in the documentation.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://github.com/anitab-org/mentorship-android/wiki/Tech-Stack
  2. Scroll down to Why use MVVM architecture?

Screenshots image

Additional context It will be useful to have this info for new contributors and for understanding the app.

Sanika1999 avatar Feb 05 '21 17:02 Sanika1999

I am not able to clone the wiki locally.Is there any way to do this?Can you guide me?

haran2248 avatar Feb 07 '21 20:02 haran2248

Hi @haran2248 I guess you can clone it to your local machine using git clone https://github.com/anitab-org/mentorship-android.wiki.git

Sanika1999 avatar Feb 07 '21 20:02 Sanika1999

image This is where I found it just scroll down on the page

Sanika1999 avatar Feb 07 '21 20:02 Sanika1999

Cool I work on this Thanks @Sanika1999

haran2248 avatar Feb 08 '21 06:02 haran2248

@haran2248 You have to be assigned this issue first try asking on zulip and someone will assign it to you

Sanika1999 avatar Feb 08 '21 06:02 Sanika1999

@haran2248 Welcome to the community. Do you still want to work on this?

epicadk avatar Feb 16 '21 17:02 epicadk

Hey @epicadk Ill try to work on it.If you want you can also try to come up with a fix

haran2248 avatar Feb 16 '21 17:02 haran2248

Hey @epicadk Ill try to work on it.If you want you can also try to come up with a fix

assigning you. Happy Documenting :).

epicadk avatar Feb 16 '21 17:02 epicadk

@haran2248 any updates ?

vj-codes avatar Feb 23 '21 11:02 vj-codes

Unassigning @haran2248 due to inactivity.

vj-codes avatar Mar 11 '21 18:03 vj-codes

Can i work on this issue??

ravi5175 avatar Apr 13 '21 13:04 ravi5175

@ravi5175 this issue is marked as 'first-timers-only'. Since you already opened a PR on this repository you can't work on this issue. Please look for other issues

devkapilbansal avatar Apr 13 '21 13:04 devkapilbansal

Hi @epicadk, i would like to work on this .

kartikraj avatar Jun 01 '21 07:06 kartikraj

@epicadk , I am trying to push but it shows access denied . I guess you need to add me as collaborator for wiki.

kartikraj avatar Jun 01 '21 11:06 kartikraj

Hi @kartikraj you need to fork the repository and do changes in your forked copy. After that open a PR. You are not supposed to make changes here.

devkapilbansal avatar Jun 01 '21 11:06 devkapilbansal

@devkapilbansal Actually , i did but i couldnt see wiki files in my forked repo. Then on searching i got to know that wiki files cannot be forked, only collaborators of wiki have the permission by default & to update wiki we need to push changes directly .

kartikraj avatar Jun 01 '21 11:06 kartikraj

Ohh ohkay, then please create a document and share it's link or a markdown file in the PR instead.

devkapilbansal avatar Jun 01 '21 11:06 devkapilbansal

Tech-Stack.md This is the file i have updated in wiki .

kartikraj avatar Jun 01 '21 12:06 kartikraj

You can also change permission for wikis for time being so i can push becuz this has to do nothing with main repo.link

kartikraj avatar Jun 01 '21 12:06 kartikraj

@kartikraj hey can you try and clone the wiki locally by this link and see if it works? https://github.com/anitab-org/mentorship-android.wiki.git

vj-codes avatar Jun 01 '21 12:06 vj-codes

@vj-codes Yes I have cloned the same and made changes, but it asks for persmission to push. You can change permission for wiki which is restricted. This may help :changing access permission for wikis

kartikraj avatar Jun 01 '21 12:06 kartikraj

Nvm, we are going to soon move documentation to gh-pages. Then these problem will not happen. @kartikraj it is not possible to give permissions as collaborators.

devkapilbansal avatar Jun 01 '21 12:06 devkapilbansal

@vj-codes Yes I have cloned the same and made changes, but it asks for persmission to push. You can change permission for wiki which is restricted. This may help :changing access permission for wikis

Even we aren't allowed to edit the WIKI 😅

epicadk avatar Jun 01 '21 13:06 epicadk

oh okay.

kartikraj avatar Jun 01 '21 13:06 kartikraj

@kartikraj any update about this? You can create a .md file and commit the changes instead

vj-codes avatar Jun 15 '21 14:06 vj-codes

@kartikraj any update about this? You can create a .md file and commit the changes instead

Okay. Only the Tech stack document right?

kartikraj avatar Jun 15 '21 15:06 kartikraj

i have created PR please check @vj-codes

kartikraj avatar Jun 17 '21 08:06 kartikraj

@kartikraj why not any PR is linked to this issue?

devkapilbansal avatar Jun 17 '21 15:06 devkapilbansal

@kartikraj why not any PR is linked to this issue?

oh sry, done now

kartikraj avatar Jun 17 '21 15:06 kartikraj