bridge-in-tech-backend icon indicating copy to clipboard operation
bridge-in-tech-backend copied to clipboard

Bugfix: Add duplicate organization name check

Open NenadPantelic opened this issue 4 years ago • 7 comments

Description

Added handling of the situation when the user tries to create the new organization with the name of some other persisted organization. Fixes #110.

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Tested through Swagger UI: image
  2. Added unit test to cover this scenario

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged

Code/Quality Assurance Only

  • [x] My changes generate no new warnings
  • [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been published in downstream modules

NenadPantelic avatar Mar 08 '21 14:03 NenadPantelic

@mtreacy002 I solved the organization name conflict too (this time it is an organization, not a program :joy: ). I expect to face merge conflicts after #189 is merged (they tackle the same files).

NenadPantelic avatar Mar 08 '21 14:03 NenadPantelic

@NenadPantelic , can you please give us update on this?

mtreacy002 avatar Apr 04 '21 04:04 mtreacy002

Sorry for the delay, I'm busy with other things. I can update this in the next two or three days. Is that OK? The same goes for #189

NenadPantelic avatar Apr 04 '21 19:04 NenadPantelic

Sure, @NenadPantelic. Thanks for responding. Will look forward to the update. Don't forget to resolve the conflict while you're at it 😉.

mtreacy002 avatar Apr 05 '21 05:04 mtreacy002

@NenadPantelic , can we please get the updates on this?

mtreacy002 avatar Apr 17 '21 21:04 mtreacy002

Hi @NenadPantelic are you still working on this?

devkapilbansal avatar Aug 03 '21 20:08 devkapilbansal

Hey, I have been busy for the past few months. I'll do my best to finish this up or to close the MR.

NenadPantelic avatar Oct 03 '21 09:10 NenadPantelic