anitab-org.github.io icon indicating copy to clipboard operation
anitab-org.github.io copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

fixing typo in the archive page under Projects

Open Esther-Wavinya opened this issue 2 years ago • 7 comments

Description

Fixes #355

Type of Change:

Code

Code quality Assurance

Bug fix (non-breaking change which fixes an issue) My PR follows the style guidelines of this project I have performed a self-review of my own code or materials

Code/Quality Assurance Only

My changes generate no new warnings

Esther-Wavinya avatar Jun 09 '22 10:06 Esther-Wavinya

@isabelcosta how do you deploy a PR and test it?

vj-codes avatar Jun 10 '22 20:06 vj-codes

@vj-codes I think from the README, that once on develop, we can merge from develop to production and it would work.

Excerpt from README: excerpt from README that mentions 3 branches that are important

isabelcosta avatar Jun 13 '22 18:06 isabelcosta

Should I just run that?

Esther-Wavinya avatar Jun 13 '22 19:06 Esther-Wavinya

Should I just run that?

yes :)

isabelcosta avatar Jun 13 '22 19:06 isabelcosta

Should I just run that?

@Esther-Wavinya did you have the chance to do this?

isabelcosta avatar Jun 21 '22 21:06 isabelcosta

Should I just run that?

@Esther-Wavinya did you have the chance to do this?

Yes

Esther-Wavinya avatar Jun 21 '22 23:06 Esther-Wavinya

Should I just run that?

@Esther-Wavinya did you have the chance to do this?

Yes

@Esther-Wavinya Did you get new changes locally? I would expect you to have files changed and pushed. Can you check that after running that, the test files were changed? cc @vj-codes The fail is detailed here on GitHub actions.

isabelcosta avatar Jun 21 '22 23:06 isabelcosta

@isabelcosta & @vj-codes I think this PR should be closed.

Esther-Wavinya avatar Sep 28 '22 12:09 Esther-Wavinya