anitab-org.github.io icon indicating copy to clipboard operation
anitab-org.github.io copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

chore: add react router to the project

Open ftonato opened this issue 3 years ago • 3 comments

Description

This pull-request introduces routes into the application, making it possible to share the page we are on with other people easily.

Fixes #294, #329

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • https://ftonato.github.io/anitab-org.github.io/#/

Checklist:

Delete irrelevant options.

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [x] I have attached link of deployed site.

Code/Quality Assurance Only

  • [x] My changes generate no new warnings

/c @isabelcosta, @brittanyjoiner15

ftonato avatar Oct 24 '21 15:10 ftonato

@ftonato hey thank you for the fix! As per the community guidelines, a contributor has to be first assigned to an issue to create a PR, I was catching up with previous commits and understand it is an effort to make the site better, but please keep the guidelines in mind next time onwards :) Since you've already created a PR, I'm assigning the issue to you now 🚀

vj-codes avatar Oct 24 '21 19:10 vj-codes

Looks good to me! Sorry this ended up being so much here, but I think the restructure is probably the right way to go about it. I was contemplating doing that when I was in there, but wasn't sure if it made sense to mess things up too much. I guess I still don't entirely understand why this makes more sense for GH pages than what we were doing before? But I am glad it's working!

GitHub Pages does not support browser history like your browser does. To overcome this issue, we need to use a Hash router instead of a browser router in our app.

ftonato avatar Oct 25 '21 15:10 ftonato

@ftonato ah that makes sense. Hence why it works on local browser but not with gh pages. Thanks for the explanation!

brittanyjoiner15 avatar Oct 25 '21 15:10 brittanyjoiner15

I'm closing outdated issues and pull-requests that are no longer relevant given how much time has passed since they were opened.

ftonato avatar Feb 23 '23 09:02 ftonato