anitab-org.github.io icon indicating copy to clipboard operation
anitab-org.github.io copied to clipboard

Feat: Revamp event card and add event info modal popup

Open Rahulm2310 opened this issue 3 years ago • 5 comments

Description

Shorten the text in the events cards, add a Read more button in the card and add a new event details modal popup to display full details of event.

Fixes #237

Type of Change:

Delete irrelevant options.

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

anitab-events-fix

Checklist:

Delete irrelevant options.

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • [x] My changes generate no new warnings

Rahulm2310 avatar Feb 27 '21 20:02 Rahulm2310

@nandini45 @keshakaneria Can you please review this PR. Thanks 🙂

Rahulm2310 avatar Feb 27 '21 20:02 Rahulm2310

@Rahulm2310 Can we keep 3 in a row? Currently there seems a lot of space on right and a bit on left side of card. What do you say @nandini45? Otherwise the modal looks perfect 👍.

keshakaneria avatar Mar 07 '21 19:03 keshakaneria

@keshakaneria Yes it can be but do we need to discuss it with the design team first?

Rahulm2310 avatar Mar 08 '21 20:03 Rahulm2310

@keshakaneria Yes it can be but do we need to discuss it with the design team first?

Yes, tagging @nandini45 again as a part of designing project to let us know if this can be done.

keshakaneria avatar Mar 09 '21 05:03 keshakaneria

@Rahulm2310 could you fix the merge conflicts? I really like what you did here. Would love to get this on track again!

isabelcosta avatar Oct 17 '21 20:10 isabelcosta