anitab-forms-web icon indicating copy to clipboard operation
anitab-forms-web copied to clipboard

Refractor code to use functional components.

Open pranay-simejia opened this issue 4 years ago β€’ 9 comments

Is your feature request related to a problem? Please describe.

As mentioned in React Docs after react-hook support, one should prefer using functional components.

Describe the solution you'd like

Convert all class based components to functional components.

Describe alternatives you've considered

for example, componentdDidMount can be replaced by useEffect hook.

pranay-simejia avatar Feb 12 '21 17:02 pranay-simejia

Can I work on this issue?

pranay-simejia avatar Feb 12 '21 17:02 pranay-simejia

@pranay-simejia I don't think this should have a priority currently. But, yeah, please wait for a maintainer to confirm/approve this issue before starting to work on the fix. Thanks πŸ™‚

Cc: @isabelcosta

Rahulm2310 avatar Feb 13 '21 16:02 Rahulm2310

@pranay-simejia , @Rahulm2310 is correct. Right now we are trying to get this project to the MVP (minimum viable product) status. You can find more information on documentation on this zulip message. However, how much effort do you think this requires? Also, could you check on Zulip if more community members feel like this is a priority?

isabelcosta avatar Feb 13 '21 21:02 isabelcosta

Switching to functional components can be done within 2 days. Single person's job. @isabelcosta

pranay-simejia avatar Feb 14 '21 09:02 pranay-simejia

Switching to functional components can be done within 2 days. Single person's job. @isabelcosta

Yeah I think there's also a vscode extension to do this tooπŸ˜… I can't remember its name πŸ€”

jalajcodes avatar Feb 14 '21 09:02 jalajcodes

Switching to functional components can be done within 2 days. Single person's job. @isabelcosta

Yeah I think there's also a vscode extension to do this tooπŸ˜… I can't remember its name πŸ€”

i think @jalajcodes you are talking abou this https://marketplace.visualstudio.com/items?itemName=wix.glean

ayan-biswas0412 avatar Feb 14 '21 09:02 ayan-biswas0412

I have also created this same issue earlier. Here is the issue number #69. If you give confirmation for this issue, I would to like to work on this.

shruti1421 avatar Feb 14 '21 14:02 shruti1421

@shruti1421 @pranay-simejia since we are currently focusing more on completion of MVP(minimum viable product) i don't think this issue is of much use at this moment (considering it will require change in a lot of files and can cause a blocker to other features as well as current PRs) this issue can be put to hold until we have enough features and workforce for managing the project

Aaishpra avatar Feb 14 '21 15:02 Aaishpra

@shruti1421 @pranay-simejia since we are currently focusing more on completion of MVP(minimum viable product) i don't think this issue is of much use at this moment (considering it will require change in a lot of files and can cause a blocker to other features as well as current PRs) this issue can be put to hold until we have enough features and workforce for managing the project

ok

ayan-biswas0412 avatar Feb 14 '21 15:02 ayan-biswas0412