anitab-forms-web icon indicating copy to clipboard operation
anitab-forms-web copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Added Google Oauth Signup

Open chinmaym07 opened this issue 3 years ago • 4 comments

Description

Fixes #111

Type of Change:

  • Code
  • Quality Assurance
  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] Any dependent changes have been merged

Code/Quality Assurance Only

  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes

For the frontend part of this issue . I took some help from @codesankalp's PR for github auth.

osp

chinmaym07 avatar Mar 05 '21 11:03 chinmaym07

@chinmaym07 Please also resolve the merge conflicts after writing test for this.

codesankalp avatar Mar 20 '21 14:03 codesankalp

@chinmaym07 Any updates?

codesankalp avatar Apr 22 '21 19:04 codesankalp

@codesankalp Sorry for the delay.. I was not well for back few days & this pr just slipped from my mind .. I have added the test & ran it locally .. It is working & resolved the conflicts & ran the npm run lint:fix to run the linters , But still the test is failing .. Can you please help me with this ....

Screenshot from 2021-05-09 22-39-07

https://user-images.githubusercontent.com/44670961/117580843-8a71a580-b117-11eb-887d-89b290192452.mp4

chinmaym07 avatar May 09 '21 16:05 chinmaym07

@chinmaym07 Can you do the suggested changes?

codesankalp avatar Jul 22 '21 16:07 codesankalp