vue-color-kit icon indicating copy to clipboard operation
vue-color-kit copied to clipboard

Adjust `sideEffects` on package.json

Open frikinside opened this issue 3 years ago • 1 comments

"sideEffects": false is causing that current webpack production builds gets the css stripped from the dist package. This prevent importing the .css like you state in the readme, because webpack is treating the .css like a sideEffect. Removing the line completly solves the issue, because no file is treated as side effect.

Replacing with this line would tell webpack that the package .cssis not a side effect that need to be striped on build.

"sideEffects": [".css"]

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [x] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] All tests are passing
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

frikinside avatar Sep 12 '21 18:09 frikinside

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anishgeorge2690/vue-color-kit/21sDZkLiRRemWr1Evn6hFVxL1952
✅ Preview: https://vue-color-kit-git-fork-frikinside-patch-1-anishgeorge2690.vercel.app

vercel[bot] avatar Sep 12 '21 18:09 vercel[bot]