aries-mobile-agent-react-native icon indicating copy to clipboard operation
aries-mobile-agent-react-native copied to clipboard

Genesis URL should be customizable

Open TimoGlastra opened this issue 4 years ago • 1 comments

The genesis url is hardcoded in genesis-utils.ts. This should (optimally) be an input paramater after which the app handles downloading of the genesis, or (less optimal, but okay) be a parameter in the downloadGenesis method

https://github.com/animo/aries-mobile-agent-react-native/blob/03c52282206dc3b7cb6a0420067c77d0bc348138/src/agent/genesis-utils.ts#L12-L18

TimoGlastra avatar Feb 04 '21 15:02 TimoGlastra

I am aware of this. My plan is to add dotenv support so testing on multiple networks will become easier. As the proposed change will only move the hardcoded url from one place to another, I don't think this is a high priority issue (correct me if I'm wrong). Therefore I think it's best to take on this issue and add dotenv support in one go.

karimStekelenburg avatar Feb 04 '21 15:02 karimStekelenburg