docs and naming are using `memcache` and not `memcached`
Title. Just a typo, but breaking changes...
Hi @avifenesh
Could you clarify?
Would you like to rename RateLimiterMemcache to RateLimiterMemcached (with d at the end) ?
It should be with Memcached since this is the right name.
But if your users are already using RateLimiterMemcache renaming will break the code.
So it's your call, I'm just pointing it out.
If you are ok with breaking changes (maybe using a new major) I can make the changes.
Could we support both names and deprecate the one with typo?
Hmm we can, yes.
It is just duplicating the files, renaming, and adding @depracted on top of the old docs
Or it can be extended from the renamed class like:
class RateLimiterMemcache extends RateLimiterMemcached {
constructor(options) {
super(options);
console.warn(
'RateLimiterMemcache is deprecated and will be removed in a future version. ' +
'Please use RateLimiterMemcached instead.'
);
}
}
I guess it should work in javascript as there is no real private methods or variables in classes inheritance.
True, probably better