PlistCpp icon indicating copy to clipboard operation
PlistCpp copied to clipboard

reserved identifier violation

Open elfring opened this issue 9 years ago • 3 comments

I would like to point out that an identifier like "__PLIST_DATE_H__" does eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Nov 10 '15 17:11 elfring

Sure. What would be your suggested convention? PLIST_DATA_H_INCLUDED

On Tue, Nov 10, 2015 at 09:11:45AM -0800, Markus Elfring wrote:

I would like to point out that an identifier like "PLIST_DATE_H" does eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

— Reply to this email directly or view it on GitHub.*

animetrics avatar Nov 10 '15 17:11 animetrics

How do you think about to make these include guards not only standard-compliant but also really unique by appending a kind of UUID?

elfring avatar Nov 10 '15 18:11 elfring

Sure.

On Tue, Nov 10, 2015 at 10:04:51AM -0800, Markus Elfring wrote:

How do you think about to make these include guards not only standard-compliant but also really unique by appending a kind of UUID?

— Reply to this email directly or view it on GitHub.*

animetrics avatar Nov 10 '15 18:11 animetrics