anime-downloader icon indicating copy to clipboard operation
anime-downloader copied to clipboard

Use another cfscrape package as dependency

Open folliehiyuki opened this issue 3 years ago • 4 comments

Describe the feature here https://github.com/Anorov/cloudflare-scrape is too out of date and broken. So on system without selenium, cites with Cloudflare will not work. selenium is rather complex to build on some OSs.

https://github.com/VeNoMouS/cloudscraper seems to still be active. Maybe we should switch to using that library instead.

folliehiyuki avatar Feb 25 '21 20:02 folliehiyuki

For v1 cloudflare, that library is no doubt an improvement. For v2 (which I believe most sites are now using), however, it doesn't work - see: https://github.com/VeNoMouS/cloudscraper/blob/229088edf45ad178befeb747ab0b0890e941da55/cloudscraper/init.py#L449-L453

Supposedly the dev did succeed with v2, but they didn't open-source it, and required payment for its usage. Considering that the issues tab has since disappeared, I do not think that decision was well received.

AbdullahM0hamed avatar Feb 25 '21 21:02 AbdullahM0hamed

yup image

Blatzar avatar Feb 25 '21 21:02 Blatzar

Sorry I didn't do the research thoroughly :) I can't find any other libraries, that are at least having some development the past few months, so they probably won't work either.

Another option: putting cfscrape as optional dependency (it won't work anyway) like selenium.

Meanwhile I will try to figure out how to get selenium to build on my system.

folliehiyuki avatar Feb 25 '21 21:02 folliehiyuki

Another option: putting cfscrape as optional dependency (it won't work anyway) like selenium.

Should just be axed tbh. Maybe some brave soul will do that at some point.

Meanwhile I will try to figure out how to get selenium to build on my system.

I feel your pain - I use this project solely on termux and the webdrivers selenium uses are pretty much an illusion there😔

AbdullahM0hamed avatar Feb 25 '21 22:02 AbdullahM0hamed