MB-Lab icon indicating copy to clipboard operation
MB-Lab copied to clipboard

Allow Slider Limit to be disabled

Open telnetr4 opened this issue 5 years ago • 10 comments

MB-Lab was built originally to create realistic humans. Sometimes, realism isn't what is wanted.

Currently all modifiers have a max of -1 to 1, however, with the removal of 4 lines in def combine_morphings this limit can be increased to -5 to 5. I am afraid that this might introduce new problems.

An addition of a GUI option to disable/enable this limit should be added. It most likely will require changing how/where this limit is added.

telnetr4 avatar Feb 19 '19 18:02 telnetr4

I think it's a good idea, there have been complaints on Blenderartists before if I recall that some wish they could go past -1 / 1. Even I wish that we could.

My only concern is that the age value, Manuel made it clear (not sure what thread I read this but I remember it being written on Blenderartists) he did not want to do underage characters, I can understand why, there are messed up people in this world and to have a character that is young, with the ability to go "nude" that this could pose an ethical issue. I am pretty sure those were his feelings and I can see where he comes from there. Not to say Blender artists are sick people at all, not my intention there, however if these potentially young models end up in someone's hands with less than honorable intentions.... it's a difficult thing to think about.

Other than THAT, I say go ahead and see what you can do.

animate1978 avatar Feb 20 '19 05:02 animate1978

My only concern is that the age value

This slider change only applies to modifiers that can be found in Body Measures. I quickly tested it and the lowest age is still 18. Even if age value was affected, its highly unlikely that the figures would look under-age as this is basically an extrapolation.

From my experience with other character creation tools like DAZ and Poser, they usually use different geometries designed specifically to create children similar to how theres a geometry tailored toward males and a separate geometry for females. As far as I am concerned we will neither work on children geometries nor work on anything for this age range.

telnetr4 avatar Feb 20 '19 10:02 telnetr4

Ah ok then. I was not sure exactly which values you were talking about, if you were combining ALL values or not. It would be interesting to see what one would look like with exaggerated morphs.

animate1978 avatar Feb 20 '19 12:02 animate1978

Update: figured out how to set the "hard limits" to different numerical values. Again, don't know if this could propagate problems.

telnetr4 avatar Feb 20 '19 20:02 telnetr4

The most basic, but probably least shareable/useful way, to impliment this would be by adding a check box to the preference page plus two textboxes to allow for the user to change the range.

telnetr4 avatar Feb 28 '19 16:02 telnetr4

I will prepare PR to change limits to soft limits with message that we do not guarantee proper working outside the default limits. @animate1978 is it acceptable? It is not worth to introduce a separate button for this use in my opinion. The UI can not be overgrown. Moreover, Blender introduce soft limits for that use.

mklemarczyk avatar Nov 09 '19 20:11 mklemarczyk

I think it's acceptable, I agree the GUI needs to stay compact, which is why there had been some GUI work done with the new additions.

animate1978 avatar Nov 10 '19 04:11 animate1978

Upon further review this might be something to explore again...

animate1978 avatar Feb 16 '21 15:02 animate1978

Limits_removed_001

Limits_removed_002

The slider cannot by default change the values past -1.0 or 1.0 BUT you can type them into the GUI directly. This does however give some less than desirable results and in certain cases will cause the mesh to fold into itself or in the "Body" value will invert the character entirely.

More testing needs to be done before committing this to the repo

animate1978 avatar Feb 19 '21 15:02 animate1978

Correction .... sliders don't go past 0 to 1 ....

animate1978 avatar Feb 21 '21 00:02 animate1978