animate.css icon indicating copy to clipboard operation
animate.css copied to clipboard

Adding swoop entrance and exit animations.

Open emmanuelulloa opened this issue 1 year ago • 13 comments

I added a set of swooping entrance and exit animations. They are inspired on the "smear" effect by Chuck Jones. Review them in this codepen: https://codepen.io/emmanuelulloa/pen/PogVYPa

emmanuelulloa avatar Apr 23 '24 17:04 emmanuelulloa

@daneden , @eltonmesquita o @warengonzaga any comment on the animations?

emmanuelulloa avatar May 08 '24 03:05 emmanuelulloa

Hello @emmanuelulloa, I like the animation, but is there anything we can do to make it more fluid? The final decision would be from @eltonmesquita.

warengonzaga avatar May 08 '24 03:05 warengonzaga

@emmanuelulloa these are great! I’d suggest adding an opacity transition in the final ~50% of each keyframe animation. The translation is quite small and it's unlikely that transitioned elements would appear “off-screen” by the end of the animation (unlike some of the current exit/entrances, which translate elements by thousands of pixels to ensure they begin/end off screen).

daneden avatar May 08 '24 09:05 daneden

@daneden I added the opacity change and you are correct; they look way more natural. Please review at the same codepen: https://codepen.io/emmanuelulloa/pen/PogVYPa

emmanuelulloa avatar May 09 '24 17:05 emmanuelulloa

@emmanuelulloa nice, this does look better, although I'd suggest the opacity transition is a bit abrupt. It looks like the transition starts at the 65% keyframe right now; I’d play around with moving it to the 51% or 57% keyframe.

daneden avatar May 13 '24 08:05 daneden

@daneden I move it to 57% (because at 51% it looked more like a regular fade). Please review and let me know what you think.

emmanuelulloa avatar May 13 '24 20:05 emmanuelulloa

@daneden le me know what you think of the latest fix. Regards.

emmanuelulloa avatar Jun 18 '24 20:06 emmanuelulloa

Hey @eltonmesquita can you take a look into this? Thanks!

warengonzaga avatar Jul 18 '24 09:07 warengonzaga

@eltonmesquita any comments on regards to this one?

emmanuelulloa avatar Sep 04 '24 22:09 emmanuelulloa

@daneden any chance you see into this before the end of 2024?

emmanuelulloa avatar Dec 03 '24 17:12 emmanuelulloa

This looks great, thanks for your adjustments! Approving to unblock. @eltonmesquita @warengonzaga you're both more familiar these days with the release process so I’ll leave it to you to approve/merge.

Thanks! I'm not sure if I have merge capability but I will do my best to help approve the PRs.

warengonzaga avatar Dec 09 '24 11:12 warengonzaga

@warengonzaga let me know if you need something from me when doing the merge.

emmanuelulloa avatar Dec 23 '24 20:12 emmanuelulloa

@eltonmesquita let me know if you need something from me for your review process.

emmanuelulloa avatar Dec 23 '24 20:12 emmanuelulloa