animate.css
animate.css copied to clipboard
animate-css
Rename delay classes (Improvement)
Problem
The classes for delaying are currently called animate__delay-2s, animate__delay-3s, ...
Which also implies that it is always "seconds", which basically is wrong and confusing, as it is a multiplier for a variable delay parameter.
Improvement
The classes should be named i.e. animate__delay-2x, animate__delay-3x, ... to better reflect, that they just delay for a specific multiplier.
hey there, good suggestion, but it would make animate.css bloated with bunch of specific multiplier. You can always change the default to your liking. What do you think @eltonmesquita?
@warengonzaga I mean, the classes should just be renamed and not something added. Instead of an "s" (for seconds) just use a "x" for times.
"animate__delay-2s" -> sounds like "delay for 2 seconds" "animate__delay-2x" -> sounds like "delay for 2 times" (where times is by default 1s, but maybe changed)
@warengonzaga I mean, the classes should just be renamed and not something added. Instead of an "s" (for seconds) just use a "x" for times.
"animate__delay-2s" -> sounds like "delay for 2 seconds" "animate__delay-2x" -> sounds like "delay for 2 times" (where times is by default 1s, but maybe changed)
that's totally make sense! Let me take this...
This seems a sensible change, I like it. As this is a breaking change, we should ship it with v5. But for the sake of compatibility, it would be very simple to support both sorts of classes (1x/1s) so devs won't need to update their code for such a simple change.
