animate.css icon indicating copy to clipboard operation
animate.css copied to clipboard

Properly update to postCSS v8

Open eltonmesquita opened this issue 4 years ago • 13 comments

Recently we updated to postCSS v8 which brings lots of changes, including how to use it and its "plugins" as dependencies in the project. Right now the building system is working but it's throwing some warn as we're not following the recommendations.

We need to fix this and get #1194 merged so everything is working nicely and in the best way possible. Help is very welcomed!

eltonmesquita avatar Dec 31 '20 11:12 eltonmesquita

I just pull the changes... and try to fix this.

warengonzaga avatar Dec 31 '20 13:12 warengonzaga

@WarenGonzaga , shout out if you need any help on this, alright?

eltonmesquita avatar Dec 31 '20 14:12 eltonmesquita

@WarenGonzaga , shout out if you need any help on this, alright?

I don't see any errors on compiling.

warengonzaga avatar Dec 31 '20 14:12 warengonzaga

Work on #1194 branch and you can see the warnings. Also, if you read postCSS docs/migration guide you'll see that it doesn't use plugins anymore even though they are supported. A bit weird but makes sense with what they're doing now.

eltonmesquita avatar Dec 31 '20 16:12 eltonmesquita

BTW, Happy New Year @WarenGonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!

eltonmesquita avatar Dec 31 '20 16:12 eltonmesquita

BTW, Happy New Year @WarenGonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!

Happy New Year too! No problem... small effort.

warengonzaga avatar Dec 31 '20 16:12 warengonzaga

postCSS and its "plugin" were updated on #1339. Now we just need to follow the migration guide to make sure we're using postCSS properly.

eltonmesquita avatar Aug 03 '21 10:08 eltonmesquita

Thumbs up! Enjoying your lib immensely, great job. But animate.css is now blocking me from using tailwind because of the lack of PostCSS 8. Cheering for you for the release, it looks like it is almost there.

sertaco avatar Nov 06 '21 12:11 sertaco

Thumbs up! Enjoying your lib immensely, great job. But animate.css is now blocking me from using tailwind because of the lack of PostCSS 8. Cheering for you for the release, it looks like it is almost there.

Hi @sertaco, we'll make sure that in our coming release the postCSS will be updated.

warengonzaga avatar Nov 06 '21 12:11 warengonzaga

@sertaco animate.css should work with tailwind no matter our postCSS version because we don't actually ship - anymore - anything related to postCSS. We only ship the minimal files needed (compiled and source CSS and package.json file). Could you detail your problem?

eltonmesquita avatar Nov 08 '21 12:11 eltonmesquita

Thanks @eltonmesquita for the explanation. my npm was complaining about animate's postcss dependency but after upgrading all packages in package.json and clean installing I do not have the error anymore. Not sure exactly why I was getting the error maybe an earlier version install remnants in lock.json. not sure but thanks, it works now.

sertaco avatar Nov 12 '21 16:11 sertaco

Thanks @eltonmesquita for the explanation. my npm was complaining about animate's postcss dependency but after upgrading all packages in package.json and clean installing I do not have the error anymore. Not sure exactly why I was getting the error maybe an earlier version install remnants in lock.json. not sure but thanks, it works now.

If it is a Warning that's good, you can ignore it. If it is an error, then you have to do something.

warengonzaga avatar Nov 14 '21 14:11 warengonzaga