Anil Yildirim

Results 49 comments of Anil Yildirim

I think I addressed all of your individual comments @sseraj. I will look into adding the hole cutting test. @lamkina, how do you suggest we approach this? Especially for cpmin,...

I documented the behavior a bit better in the options.yaml file, and also changed the code slightly so that it returns zero when the option `computeCavitation` is set to False.

I have updated the PR description to help reviewers. Do we want to have different people review different features, @eirikurj? I might have missed stuff, but I tried to point...

Thanks for the review, @sseraj. I made the suggested change in the docstring so now the `addPointset` link appears in the sentence without breaking the flow. I think one item...

As we have been talking to people, we figured it would probably be easier if different people reviewed different parts of this PR (sorry @sseraj). @marcomangano, can you review the...

What is the status on this PR? @eirikurj @marcomangano do you have any chance to take a look soon and approve the relevant parts to you?

I am fine with keeping it in by default. the only problem is I think with KNL nodes, it may not work. Not sure about the details there, but I...

I addressed the low-hanging fruits @eirikurj. I have left a few questions for you to make sure I got them right. Once you confirm, I will make the remaining changes.

I created 2 issues that keeps track of the missing documentation/testing from this PR. The overset hole cutting in #251, and slice documentation in #250. These are to address comments...

@eirikurj, see this commit: https://github.com/mdolab/adflow/pull/231/commits/828f0b1e46be6f4e8d7be58852afc5c9cde44f56 for the changes regarding to reducing code duplication for slices. At the end of the day, there's not that much code duplicated, so I decided...