f1-telemetry-go icon indicating copy to clipboard operation
f1-telemetry-go copied to clipboard

Define enums for for status values, wheel-corners etc

Open advisoft opened this issue 4 years ago • 7 comments
trafficstars

What do you think about that?

I am doing that locally on my end, but I can start making pull requests for them if you are interested?

e.g.

const (
	rearLeft = iota
	rearRight
	frontLeft
	frontRight
)

then

.BrakesTemperature[frontRight]

Maybe in the packets package?

advisoft avatar Jul 20 '21 03:07 advisoft

Yeah, seems logical.

I think the code will be more human-readable if we write the values ​​by hand instead of typing them as iota.

anilmisirlioglu avatar Jul 20 '21 04:07 anilmisirlioglu

Yep not worried, just whatever you want.

Will make a pull request in the next few days.

Hey another thing, there is no way to terminate after calling run as far as I can tell. I can sort that out too if you want?

advisoft avatar Jul 20 '21 04:07 advisoft

Sounds good, If you have a good solution that would be nice. I'll be waiting for your PR request.

also after stabilizing a bit more, I'm planning to start implementing the 2021 UDP specs.

anilmisirlioglu avatar Jul 20 '21 04:07 anilmisirlioglu

Hi @advisoft, are you still considering doing this issue?

anilmisirlioglu avatar Jul 27 '21 14:07 anilmisirlioglu

Yep, next couple of days.

advisoft avatar Jul 28 '21 00:07 advisoft

Been off work sick, got quite a backlog to get thru before I can progress on this.

advisoft avatar Aug 04 '21 04:08 advisoft

no problem ^^

I added a little something about it: 67ea6d6f6dee86d6c71098f900fbf47f0aa87d74

anilmisirlioglu avatar Aug 04 '21 07:08 anilmisirlioglu