anicolao

The root cause of this issue is that the protocol has changed for the i3. It advertises new services and there is a new way of discovering what the correct...

I probably interpret clean room too strictly to be of any use to you. While I am interested in i3 support, I have already read code that explains how the...

I will refrain from more commentary on this issue, other than to say that I know it to be more complicated than you describe. So possibly refactoring the code so...

I am not sure how compatible the way I am thinking about it is with the plan you have in mind. Let's see if they match up in a nice...

Here's an ugly patch that does most of what I want. Probably this needs to be rethought. ``` diff --git a/src/cubing/bluetooth/smart-puzzle/gan.ts b/src/cubing/bluetooth/smart-puzzle/gan.ts index 8e9d8eda..d774eb67 100644 --- a/src/cubing/bluetooth/smart-puzzle/gan.ts +++ b/src/cubing/bluetooth/smart-puzzle/gan.ts @@...

In trying to implement wide moves (r, u, etc) I discovered that the hacky approach is really quite the wrong way to go about it, and I will replace `ganMoveToBlockMove`...

Here is what I consider the 'minimal' patch: ``` diff --git a/src/cubing/bluetooth/smart-puzzle/gan.ts b/src/cubing/bluetooth/smart-puzzle/gan.ts index 8e9d8eda..85b29163 100644 --- a/src/cubing/bluetooth/smart-puzzle/gan.ts +++ b/src/cubing/bluetooth/smart-puzzle/gan.ts @@ -351,8 +351,13 @@ export class GanCube extends BluetoothPuzzle {...

And here is a better patch based on that for adding all the slice moves. Orientation is coming but will take longer to write up as it took me a...

OK after a day of futzing with it I have come to the conclusion that the way to keep the bluetooth layer robust and simple is to have it issue...

I haven't figured out how testing is meant to be done for this project, but meanwhile here is a version of the patch with all lint and typescript errors fixed....