AMII icon indicating copy to clipboard operation
AMII copied to clipboard

Have always sound on test completion.

Open Legion112 opened this issue 2 years ago • 10 comments

I would like to force always have sound notification on test failer. This would help me to return back to work after long time of procastination during waiting for test result.

Legion112 avatar Sep 06 '22 19:09 Legion112

Not all memes have sound. So, I think @Unthrottled could add an option to show just memes with sound for build results like successful built, build failed and etc.

Dragon-0609 avatar Sep 06 '22 19:09 Dragon-0609

That would be greate.

Legion112 avatar Sep 06 '22 19:09 Legion112

Where I can see list of meme wich has sound? Maybe I could limit only those which has it?

Legion112 avatar Sep 06 '22 19:09 Legion112

Here you can see all memes: https://amii-assets.unthrottled.io/

Dragon-0609 avatar Sep 06 '22 19:09 Dragon-0609

I think at the moment there's no filter for memes with and without sounds in that website. So, you can just press in every meme and see if it has the sound.

Dragon-0609 avatar Sep 06 '22 19:09 Dragon-0609

Ah yeah, the older version of the plugin used to randomly associate a sound to a visual asset (I think, don't remember). So I feel it's fair to resurrect it.

Anyways, with custom assets, I think I can add the ability for users to provide a pool of sound assets. They can be tagged with: Positive, Negative, Neutral (or some other mapping) that allows me to associate a visual asset with an audible asset.

Then I can add a setting for each event type (startup, test, exit code, etc) as to whether play a random sound, from the random audible asset pool, on event dispatch.

I might work on this sooner if I feel like procrastinating on what I am currently working on.

Unthrottled avatar Sep 06 '22 22:09 Unthrottled

Could you provide a list of command what need to be run in order to build project? So contribution would be mush simpler. @Unthrottled

Legion112 avatar Sep 08 '22 06:09 Legion112

The plugin uses the intellij gradle plugin. So you can follow the plugin guide provided by JetBrains.

I'd appreciate contributions, however this is a fairly involved feature. So I'd like something that I can easily maintain. I've got some requirements I'll list if you are wanting implement this.

Unthrottled avatar Sep 08 '22 10:09 Unthrottled

@Unthrottled sure you could list it.

Legion112 avatar Sep 08 '22 10:09 Legion112

To keep the initial feature simple, I'm would prefer if the scope remain just to the test events.

  • Users should be able to opt-in to playing a random sound on test event completion.
  • On test event emission, If the visual asset doesn't have an associated sound asset, then random sounds played must be chosen from the appropriate custom sound asset, as the bundled sounds don't have the appropriate metadata to provide the below requirements.
  • If the test event is negative, then I expect to it to randomly pick a sound that was categorized as negative.
  • If the test event is positive, then I expect it to randomly pick a sound that was categorized as positive.
  • I expect the plugin to diversify the random choices, so I don't hear the same random sound all the time. (You can use the weighted list selection feature)
  • I expect to be able to create a directory on my compute, place sound files in it, and then be able to categorize the sound assets in the plugin settings menu.
  • I expect an option for the plugin to automatically create sound auto labeling directories if opted into. This should work almost the same as the existing auto labeling, just with the positive/negative categories.
  • I expect the plugin to remove any reference to deleted sound assets when the asset directory is scanned.

This list isn't exhaustive, but I think it is a good start.

Some extra references:

https://github.com/ani-memes/AMII/issues/151#issuecomment-1188431985 https://github.com/ani-memes/AMII/pull/153

If that's too much work, you can always just Only use custom assets and always provide sound for your custom assets :)

Unthrottled avatar Sep 08 '22 11:09 Unthrottled