libepoxy icon indicating copy to clipboard operation
libepoxy copied to clipboard

Published 20 hours ago • verified publisher icon anholt

Fix static build (DllMain)

Open melroy89 opened this issue 2 years ago • 9 comments

Do not include the DllMain entry point in the static build, only when it's a shared build.

melroy89 avatar Dec 06 '21 20:12 melroy89

@ebassi Maybe you want to look at this PR?

melroy89 avatar Dec 10 '21 21:12 melroy89

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

ebassi avatar Dec 10 '21 21:12 ebassi

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

ebassi avatar Dec 10 '21 21:12 ebassi

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

I understand, no blame.

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

I agree. I guess, we can extend the github action workflow file with a static build: https://github.com/anholt/libepoxy/blob/master/.github/workflows/msys2.yml

melroy89 avatar Dec 10 '21 23:12 melroy89

Ping? (sorry to just bother you, otherwise I don't see this getting merged)

melroy89 avatar Feb 25 '22 23:02 melroy89

Any feedback?

melroy89 avatar Mar 02 '22 22:03 melroy89

I would appreciate if this is supported upstream as well.

theartful avatar Jun 03 '22 16:06 theartful

I would appreciate if this is supported upstream as well.

Me too that is why I created this pr. @ebassi @anholt somebody?

melroy89 avatar Jun 03 '22 17:06 melroy89

Is it really enough to not compile DllMain? Wouldn't it take an alternative way to do the initialization which is in the body of this function?

dg0yt avatar Jul 02 '23 17:07 dg0yt