Angus Lees

Results 86 comments of Angus Lees

You mean https://github.com/mmikulicic/rules_ksonnet ? ;)

> Any updates? I remain extremely reluctant to maintain more than one build system without a strong reason. I appreciate that bazel BUILD files can be autogenerated quite effectively using...

We should continue the above investigation, but for context I note we read-write mount the host's `/var/log` (can rewrite logs) and `/var/run/docker{,shim}.sock` (host root equiv) into the aws-node container. We...

This was closed prematurely, so just reopening so we don't lose the remaining action item raised earlier. #955 moved the literal `privileged=true` Kubernetes option to an earlier init container, but...

When are we removing the dockershim.sock mount from the aws-node manifest? I think we should do it in this PR, since it is coupled to this code change anyway.

> Closing this PR since this will be handled as part of v1.11.0 release I don't think this happened as part of v1.11 release? As far as I can see...

(noise comment to reset the stale counter)

SPEC.md now says: > A container must be uniquely identified by a ContainerID. Plugins that store state should do so using a primary key of (network name, CNI_CONTAINERID, CNI_IFNAME). .....

Yep, will do. I'm trying to write a test case, but I think #862 means it's always equivalent to ignoring the prevResult.cniVersion (which is also how this bug presents)? What's...

I know we don't need a list of examples, but serde seems worth a special mention here. It's a complex, popular, amazing library that at the bottom just writes/reads from...