lagrangian-filtering icon indicating copy to clipboard operation
lagrangian-filtering copied to clipboard

Frequency space filter test is likely broken

Open angus-g opened this issue 3 years ago • 0 comments

For consistency with the analysis module, we should probably use da.fft in the FrequencySpaceFilter. We've already learned that fftfreq expects a sample spacing (rather than frequency), so the fs argument in test_frequency_filter is wrong. We should also be careful about angular vs. linear frequencies (there's probably a factor of 2*pi missing in the test/filter).

angus-g avatar Mar 17 '21 04:03 angus-g